Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] RBAC privielge group and grant v2 api #849

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from master: #845, #847
issue: milvus-io/milvus#37031

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 November 21, 2024 10:09
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 21, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (fc46c0c) to head (8e03b7e).
Report is 1 commits behind head on v2.4.x.

Additional details and impacted files

Impacted file tree graph

@@      Coverage Diff      @@
##   v2.4.x   #849   +/-   ##
=============================
=============================

@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Nov 26, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 26, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Nov 26, 2024
@sre-ci-robot sre-ci-robot merged commit 564e928 into milvus-io:v2.4.x Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants