Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: RBAC grant v2 API #847

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

shaoting-huang
Copy link
Contributor

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 November 20, 2024 09:59
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 20, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 20, 2024
Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm look good to me label Nov 21, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Nov 21, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 21, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gltm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Nov 21, 2024
@congqixia
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3f8c372 into milvus-io:master Nov 21, 2024
7 checks passed
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants