Handle transactions without royalties #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #58 , this was because the buyer chose not to have royalties. In the original /src/lib/marketplaces/helpers.ts file, this block exists:
} else if (transfers.length === 1) { // There should be more than one transfers as all NFT contains royalties and seller revenue return null; }This is invalid because royalties are now optional and it seems most buyers choose not to pay them.
Also. yarn.lock causes the Dockerfile to fail building, and even then it still fails to build because of a type conflict. So I just tore the dockerfile down entirely.