Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not picking up ME sales #58

Open
DataKnox opened this issue Dec 10, 2022 · 7 comments
Open

Not picking up ME sales #58

DataKnox opened this issue Dec 10, 2022 · 7 comments

Comments

@DataKnox
Copy link

Txn IDs for testing:
3poy494S99cQumQ7b7vitzgeh1PirVhCgxHgn1KkivRWJMUqXoWyLrnXwBeSyQoMUzsTRFJLrRQwHKWymv5oKZ1Y
4DP7nozRC7GBF5av2nVsz8AZ1brr9RErznuxyEHEfpDVjtAJs9hXnsHYsz6NoiWd6zcy7HoFbFvMWm7M5y4YsMt7
2RBY52vtWE5v8enniqCRPw8CaMAYik2A2mBUizrvEPt9xMkYwaSU7rnnMeREo1PchjVEtEZH2zmDCnGR4hH2gQ5x

Using the test endpoint, these all return no NFT sale found or no transaction found.

@kryptoj
Copy link
Collaborator

kryptoj commented Dec 16, 2022

Hmm, this seems to be related to #55 where Candy machine v2 changed the way it processes royalties which renders the parsing transaction logic useless. Have you tried the latest version? You will have to update the environment variable. https://github.com/milktoastlab/SolanaNFTBot#magic-eden-variables

@DataKnox
Copy link
Author

Yes, the version I was building from was 5 days old from when I opened this issue. You're right that this is related to how ME handles royalties. I submitted #59 - a PR to address

The code breaks when it sees only 1 transfer of SOL, expecting there to be multiple transfers (to the seller, and to the creator for royalties)

@kryptoj
Copy link
Collaborator

kryptoj commented Dec 17, 2022

Hrmm that's a bug. The latest version shouldn't rely on parsing the transaction anymore. New sales should get picked up by hitting MagicEden's API instead. Is that not working for you? Have you turned it on by setting the new MagicEden Env vars?

@DataKnox
Copy link
Author

My ME variables are set and I'll add that it is not picking up sales from the Hot Heads collection. I have to remove the block that was in the PR, then hit the test endpoint with the transaction ID in order to get it to work. Unless I've configured it wrong somehow?

@kryptoj
Copy link
Collaborator

kryptoj commented Dec 18, 2022

Interesting. What was your environment variable?
I can see the sales activity by hitting the API using hot_heads as the value.

https://api-mainnet.magiceden.dev/v2/collections/hot_heads/activities?offset=0&limit=100

@DataKnox
Copy link
Author

ME discord channel env var is my target channel ID

ME api base url I've left unchanged

ME collection key is hot_heads

@lfmistrinel
Copy link

XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants