Remove proces.env.EMBER_CLI_FASTBOOT

[kratiahuja]

Since your addon is using process.env.EMBER_CLI_FASTBOOT for including scripts in the base page, this change is backward incompatible . You could leave your addon in the current state and it will work as is or chose to merge this and do a major version bump to support FastBoot 1.0.

Fixes the addons in ember-fastboot/ember-cli-fastboot#387

cc: @mike-north

[mike-north]

I'm not sure I understand how this would work. The included script requires parts of the DOM API that simple-dom doesn't support. Have you confirmed that fastboot builds don't throw errors or blow up?

[kratiahuja]

@mike-north You are including the script in the base page (index.html). The script isn't downloaded in the fastboot environment since it is part of the base page. If it was included in vendor.js or app.js it would be eval'd.

The reason you have this check is so that you don't have the two same script tags since the beta releases of fastboot addon do double builds. With FastBoot 1.0 (soon to be released), there isn't double build and this environment flag isn't there. If you merge this PR, you will need a major version bump since your addon cannot support both versions (in this case). If you chose to keep it as is (ie not merge this PR), it will work in both versions but that check is not needed. Hence the PR.

Yes I did test it with assuming you'll do a major version bump.