-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-ons Prep for fastboot 1.0.0 #387
Comments
@stefanpenner nice little script! 👌 I wonder if we could come up w/ something similar that takes this list and automatically creates an issue on each github repo? That way we could build awareness amongst the respective addon authors. Put links to @kratiahuja's guide and other helpful information into the template used to create the issue text... I started some migrations by myself just to prepare addons that we use in our own app, but given the size of that list, and the fact that it actually grew quite a bit during the last weeks, I think we have to inform addon authors sooner than later, and rely on them making the necessary changes! |
Totally, and this would in-general be a super useful tool. I unfortunately don't have the time, but would love it to exist (hint hint, if you have time). |
Hm, I can give it a try over the weekend I hope... |
@stefanpenner finally got this tool finished, did underestimate the effort a bit, but anyway here it is: It uses the same logic as your shell script to fetch addons that need to be fixed, based on the emberobserver.com code search API, then checks if there is any existing open issue/PR containing "FastBoot 1.0" (skips those), and then creates an issue like this one: simonihmig/fastboot-migration-issue-creator-dummy-addon#6 If you see something that should be changed here, feel free to create an issue on its repo. Otherwise if that looks fine, I could run that script to create all those issues. If you prefer that to be done with some others github account, that would be ok for me as well... cc @kratiahuja |
@simonihmig very cool. I will try and give it a whirl this weekend! |
@simonihmig super awesome! will give it a try! |
@kratiahuja @stefanpenner Sure, play with it. Just make sure to either use the |
PR for ember-inputmask: adopted-ember-addons/ember-inputmask#39 I hope it's the correct way of fixing it because I'm not too familiar with FastBoot. If someone could help review the PR then it would be awesome. Thanks for the great work! |
ahmadsoe/ember-offline#4 Couple of PRS out to work with Fastboot for these libraries |
v1.0.0 is live and we have a sufficient mass of updated addons that the rest can copy. |
Can someone help me with this? In the examples, it seems awfully simple. But I seem err on every attempt. gmurphey/ember-masonry-grid#58 (comment) Disclaimer: I've never developed plugins for ember, just trying to get this to work so I can update my old fastboot. |
Pre-req
What/Why?
The upcoming ember-cli-fastboot 1.0.0 release has some breaking changes, although we try hard to avoid any breaking changes these ones are hard to avoid (and we feel worth it) they:
ember fastboot --serve
andember s
How to upgrade:
@kratiahuja's upgrade guide: https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c
Addons
List of add-ons that match: https://emberobserver.com/code-search?codeQuery=process.env.EMBER_CLI_FASTBOOT
To check them off they should be either ready for 1.0.0, and add a link to any active PR that enables 1.0.0
*note: script for ^ https://gist.github.com/stefanpenner/ff5be0c7c2a3aabed49dd00fda8fd461 *
The text was updated successfully, but these errors were encountered: