GitHub Actions for Running Unit Tests

[hanhqvu]

What it Does

• Closes GitHub Actions for Running Unit Tests #53
• This PR added Fastlane config files with a unit tests lane to the project along with a Github Actions to run unit tests on PR to the dev branch

How I Tested

• I added the file to the dev branch and ran the workflow manually:
• https://github.com/hanhqvu/Basic-Car-Maintenance/actions/runs/6463272753/job/17546186299
• Please also refer to the screenshots below for more details

Notes

• This could be replicated for GitHub Actions for Running UI Tests #54 by adding another lane & changing the 'only_testing' parameter

Screenshot

[mikaelacaron]

Great work!! I have a couple of questions. I'm not terribly familiar with fastlane, so maybe some of these are basic haha

[mikaelacaron]

Should we run on 13 or later?

[hanhqvu]

Yeah, I think that's possible

[hanhqvu]

It seems there are less runners for macOS 14 so Github Actions will wait for until 1 is available.
This might take up to 10 minutes so I think macOS 13 would be fine for now.

[mikaelacaron]

I can't figure out how to test this locally, I thought you could still run lanes locally, but I don't have it set up right, because I get this error, which I'm guessing is it's not connected properly to Ruby, but who knows haha, so I'm going to merge it and see what happens!

Good work!

The `fastlane' command exists in these Ruby versions:
2.7.2

[hanhqvu]

I can't figure out how to test this locally, I thought you could still run lanes locally, but I don't have it set up right, because I get this error, which I'm guessing is it's not connected properly to Ruby, but who knows haha, so I'm going to merge it and see what happens!

Good work!

The `fastlane' command exists in these Ruby versions:

2.7.2

You might want to try bundle exec fastlane unit_tests

[mikaelacaron]

@hanhqvu I still get that error above when I try to run that command

[hanhqvu]

That's strange. Maybe it's because I installed Ruby as a dependency for some other homebrew package.

[mikaelacaron]

🤷‍♀️ haha I'm not sure, I'm not super familiar with fastlane, but it seems like the unit tests worked haha
I know a few people I can ask, but if you know of a good iOS tutorial, drop it here and I'll take a look! Thanks!

[hanhqvu]

I'm not too familiar myself haha.
I mostly just followed Fastlane doc.
I'll drop a link here if I found something interesting.

[hanhqvu]

@mikaelacaron Just a quick check, have you done the Fastlane setup yet?

[mikaelacaron]

yup! Except haha I just read through it again, I was using homebrew to install fastlane, and now I just ran the sudo gem install fastlane, lol soo.... I'm not sure how if that will affect anything 🤷‍♀️

[mikaelacaron]

Okay now I was able to run bundle exec fastlane unit_tests when it was installed with gem rather than homebrew 🤷‍♀️
haha do you think I should remove the installation with homebrew?

[hanhqvu]

That's good to know! Probably a good idea to remove the homebrew installed fastlane I think, might lead to some conflict due to 2 versions of ruby.

[mikaelacaron]

done! thanks for the help! Do you know if I should commit the Gemfile.lock? It keeps coming up anytime I use a fastlane command

[hanhqvu]

Yes, please feel free to do so! I also think we should update the Readme with info on Fastlane and its dependencies.

[mikaelacaron]

@hanhqvu you could make a new issue that does this 👍

Also update contributing, I think it's not essential, and mention that it's only needed if using fastlane for running tests, but otherwise it's fine

Also add documentation in the DocC documentation about how it works could be a good place too

[hanhqvu]

@mikaelacaron I haven't done anything with DocC yet so happy to try it out! Will follow up on this after I'm done with the other issue.

[mikaelacaron]

Yeah I wouldn't worry about it, I can also make a new issue too for someone else to add it

[anupdsouza]

Hey @hanhqvu @mikaelacaron , could you check if the workflow succeeds even if there is a test case error? I was trying CI/CD myself by replicating the changes in this PR and I found that the workflow succeeded but it did not run any of my tests in a demo project where I purposefully introduced a test case failure.. I also could not see any logs that printed the different test case classes as well. Maybe that has something to do with the yml configuration. I'm sorry if this is off-topic.

[hanhqvu]

@anupdsouza I think I made a mistake with the Fastlane file.

@mikaelacaron Should I make this into an issue?

[hanhqvu]

FYI, this should be the result if a test failed.

[anupdsouza]

That's what I was expecting to see! @hanhqvu do you see the same behaviour on here as well in the workflow? I'm not at my desk at the moment so I can't try it out myself.

[hanhqvu]

As mentioned, I think I made a mistake with Fastlane setup to run unit tests. Waiting on Mikaela on the correct workflow to fix this.

[mikaelacaron]

@hanhqvu Yes, go ahead and make a new issue and describe what's happening!
@anupdsouza Thanks for noticing this!

[hanhqvu]

@mikaelacaron Added #173!
@anupdsouza If you are interested, feel free to assign the issue to yourself!
Otherwise I will get to it once my other PR is merged.