Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions for Running Unit Tests #53

Closed
mikaelacaron opened this issue Oct 3, 2023 · 9 comments · Fixed by #123
Closed

GitHub Actions for Running Unit Tests #53

mikaelacaron opened this issue Oct 3, 2023 · 9 comments · Fixed by #123
Assignees
Labels
feature request New feature or request good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed

Comments

@mikaelacaron
Copy link
Owner

mikaelacaron commented Oct 3, 2023

Describe the feature you want the app to have that it currently doesn't

  • Create a CI script in the properly place in the .github directory for running a CI script to run the unit tests
  • Trigger the script to run when there is a PR to dev or main, and it can be run manually

Describe alternatives you've considered

  • I don't believe you can test this at all, on the repo because it needs to be approved my @mikaelacaron , you may need to create it in your own project, run it and test it, and then once you know this syntax is right, make a PR and Mikaela can try it on this repo

Additional context

  • Only run the unit tests. I'll make a different issue for running UI tests
@mikaelacaron mikaelacaron added feature request New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest labels Oct 3, 2023
@mikaelacaron
Copy link
Owner Author

@am2089 if you want to work on this still, comment here and I can officially assign it to you!

@mikaelacaron mikaelacaron changed the title FEATURE - GitHub Actions for Running Unit Tests GitHub Actions for Running Unit Tests Oct 3, 2023
@am2089
Copy link
Contributor

am2089 commented Oct 3, 2023

Yes I would love to!

@hanhqvu
Copy link
Contributor

hanhqvu commented Oct 9, 2023

Hi again @mikaelacaron,

Since the original assignee removed themselves, can I tackle this next once my other PR is merged?

@mikaelacaron
Copy link
Owner Author

Yes! you got it! See previous PRs, there were some issues running the unit tests from GitHub actions, it may be possible to run this from fastlane instead, possibly collaborating with the contributor on #54 may help

@hanhqvu
Copy link
Contributor

hanhqvu commented Oct 9, 2023

@mikaelacaron I tried it but there were some error about device large not being available.
During research, I came upon this issue: actions/runner-images#551
This seems to be an issue related to Github Action itself so moving to Fastlane would be a better option imo.

@mikaelacaron
Copy link
Owner Author

Sounds good! Let's do it, using fastlane!
We don't really have to install anything into the project right? It's more about installing fastlane on a person's individual machine, if they want to run a lane? right?

@hanhqvu
Copy link
Contributor

hanhqvu commented Oct 9, 2023

That's correct! Fastlane also have setup to integrate with Github Action.
I will try to do that and let you know the result.

@mikaelacaron
Copy link
Owner Author

Sounds good thanks! Feel free to DM me on social media, if you need me to do something specific with the repo setup, if needed

@hanhqvu
Copy link
Contributor

hanhqvu commented Oct 10, 2023

I was able to get it to work with both Xcode CLI & Fastlane but considering Fastlane has easier to understand syntax,
I proceeded with Fastlane.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Basic Car Maintenance Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

3 participants