Sync main to feature/storage-stg87 (Azure#4407)

* update comment (Azure#4364)

* update comment

* jghjg

* update broken link

* Update sdk/keyvault/tools/cleanup/src/cleanup.cpp

Co-authored-by: Anton Kolesnyk <[email protected]>

---------

Co-authored-by: Anton Kolesnyk <[email protected]>

* Docker comment (Azure#4375)

* update comment

* add comment about vcpkg

* dsfs

* Trigger`keyvault` on proxy changes (Azure#4343)

* autotrigger the keyvault and storage CI when a testproxy file is changed

* Generate API review for C++ using new parser (Azure#4302)

* Add vmImage back to common perf.yml - Fixes Azure#5466 - Partially reverts Azure#5456 (Azure#4376)

Co-authored-by: Mike Harder <[email protected]>

* Fix pipelines path (Azure#4358)

* test path

* qwq

* dsda

* asas

* dsada

* sdsds

* Update sdk/keyvault/azure-security-keyvault-certificates/perf-tests.yml

Co-authored-by: Mike Harder <[email protected]>

* Update sdk/keyvault/azure-security-keyvault-certificates/perf-tests.yml

Co-authored-by: Mike Harder <[email protected]>

* remove warmup

---------

Co-authored-by: Mike Harder <[email protected]>

* Test proxy & storage tests improvements (Azure#4241)

* Temporarily pin Node 18 to 18.13.0 - Fixes Azure#5536 (Azure#4378)

Co-authored-by: Mike Harder <[email protected]>

* Storage tests improvement (Azure#4382)

* Update CODEOWNERS (Azure#4380)

* show headers and query parameters in storage CI pipeline (Azure#4379)

* Sync eng/common directory with azure-sdk-tools for PR 5431 Azure#2501

Co-authored-by: Konrad Jamrozik <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 5562 (Azure#4384)

* Add todos to update packages to pick up the newest CODEOWNERS interpreter

* update

---------

Co-authored-by: Konrad Jamrozik <[email protected]>

* Fix Share Client failure Azure#4377 (Azure#4381)

* Fix Share Client failure Azure#4377

* decrease request count to avoid throttling errors for storage tests (Azure#4385)

* Sync eng/common directory with azure-sdk-tools for PR 5568 (Azure#4387)

* we encourage folks to place their assets.jsons at the package level

* update generate-assets-json.ps1 to only include src/**/session-records so as to avoid picking up the duplicated 'target' sessionrecords

---------

Co-authored-by: scbedd <[email protected]>

* Add support to ignore invalid cert common name (Azure#4361)

* update to version 7.4 for admin. update tests (Azure#4388)

* update proxy version to include Info/Active against individual sessions + allow delayed response (Azure#4391)

Co-authored-by: scbedd <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 5540 (Azure#4396)

* add parameter to set cadl emitter options

* remove emitter name in the additional parameter

---------

Co-authored-by: chunyu3 <[email protected]>

* Follow-up to update changelog to reflect community contribution (Azure#4393)

* Follow-up to update changelog to reflect community contribution

* Upgrade cspell version from 0.1 to 0.2

* logging api post request body (Azure#4404)

Co-authored-by: Albert Cheng <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 5595 (Azure#4400)

* Use "npm ci" to install cspell and respect package-lock.json

* Review feedback

* Pipe npm ci output to Write-Host

---------

Co-authored-by: Daniel Jurek <[email protected]>

---------

Co-authored-by: George Arama <[email protected]>
Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Praven Kuttappan <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: JinmingHu <[email protected]>
Co-authored-by: Konrad Jamrozik <[email protected]>
Co-authored-by: chunyu3 <[email protected]>
Co-authored-by: Ahson Khan <[email protected]>
Co-authored-by: Albert Cheng <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>

eng/common/pipelines/templates/steps/check-spelling.yml

@@ -18,8 +18,8 @@ steps:
     - task: NodeTool@0
       condition: and(succeededOrFailed(), ne(variables['Skip.SpellCheck'],'true'))
       inputs:
-        versionSpec: 18.x
-      displayName: Use Node.js 18.x
+        versionSpec: 18.13.0
+      displayName: Use Node.js 18.13.0
 
     - task: PowerShell@2
       displayName: Check spelling (cspell)