Get entity api #5456
Merged
Get entity api #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gearama
requested review from
LarryOsterman,
antkmsft and
ahsonkhan
as code owners
antkmsft
reviewed
Mar 19, 2024
antkmsft
approved these changes
Mar 19, 2024
ahsonkhan
reviewed
Mar 19, 2024
Comment on lines
+310
to
+312
| * @return Entity list paged response. | ||
| */ | ||
| Response<Models::TableEntity> GetEntity( |
There was a problem hiding this comment.
The comment doesn't match the Response<T>. It isn't a paged response.
Comment on lines
+474
to
+478
| if (GetParam() == AuthType::Key) | ||
| { | ||
| EXPECT_TRUE(true); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why do we have this type of parameterized test if it doesn't make sense here? Deserves a comment.
Comment on lines
+837
to
+841
| auto const httpStatusCode = rawResponse->GetStatusCode(); | ||
| if (httpStatusCode != Core::Http::HttpStatusCode::Ok) | ||
| { | ||
| throw Core::RequestFailedException(rawResponse); | ||
| } |
There was a problem hiding this comment.
Do we have a test for the non-happy error path here?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get just one entity , this api was also requested in the api review
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.