Task/telemetry capture English theme names only #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a to ensure that component name is always in English
Add staging Application Insights instrumentation key
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-958.centralus.azurestaticapps.net |
thewahome
reviewed
May 20, 2021
thewahome
approved these changes
May 20, 2021
millicentachieng
deleted the
task/telemetry-capture-english-theme-names-only
branch
thewahome
added a commit
that referenced
this pull request
Jun 8, 2021
* Task: Add Cred Scan (#937) * Task: telemetry capture English theme names only (#958) * Feature: add telemetry middleware (#961) * Task: Capture deployed version of application for all telemetry data collected (#964) * Task: Enable autocollection of unhandled exceptions (#963) * Fix: prevent running empty requests (#972) * Task: add code-owners (#969) * Task: send notification when release is created (#967) * Fix: interaction in progress (#976) * Feature: Display Graph Explorer Version (#977) * Feature: show delta links when property is present (#978) * Feature: Intergrate OCV feedback (#923) * Fix: mgt story links (#981) * Task: Update README.md for Azure auth steps (#982)
thewahome
added a commit
that referenced
this pull request
Jun 10, 2021
* Task: Update version number (#951) * Task: telemetry capture English theme names only (#958) * Feature: add telemetry middleware (#961) * Task: Capture deployed version of application for all telemetry data collected (#964) * Task: Enable autocollection of unhandled exceptions (#963) * Fix: prevent running empty requests (#972) * Task: add code-owners (#969) * Task: send notification when release is created (#967) * Fix: interaction in progress (#976) * Feature: Display Graph Explorer Version (#977) [Disabled] * Feature: show delta links when property is present (#978) * Fix: mgt story links (#981) * Task: Update README.md for Azure auth steps (#982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have been collecting telemetry for the themes that our users are opting to use. I have noticed that some them names are captured in other languages depending on the users locale.
Fix
I am using the
selectedTheme.keyinstead which is lower case and hyphenated. I'm replacing the hyphen with a space and capitalizing the first letter. e.g.high-contrast=>High contrast