Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Intergrate OCV feedback #923

Merged
merged 122 commits into from
Jun 8, 2021
Merged

Feature: Intergrate OCV feedback #923

merged 122 commits into from
Jun 8, 2021

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Apr 7, 2021

Overview

Add feedback button to enable users to submit feedback on GE
Fixes #582

Demo

image

Notes

  • Create wrapper for the feedback form
  • Create a button to trigger the form
  • Style the button in GE colors
  • Customize feedback form
  • Connect the form to the OCV backend
  • Ensure the form generated is accessible
  • Localisation of form
  • Code refactoring
  • Change campaign ID and audience group
  • Get and send tenant ID and User ID with feedback

Known Issues

  • The form doesn't have a dark theme or high contrast theme set.

Testing Instructions

  • Open GE
  • Navigate to the 'Got Feedback' tab item and select it.
  • Observe feedback form displayed

@ElinorW ElinorW requested a review from thewahome April 7, 2021 07:46
.npmrc Outdated
Comment on lines 1 to 3
registry=https://office.pkgs.visualstudio.com/_packaging/Office/npm/registry/

always-auth=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: what does this help with?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm package is only available via the Office feed
This helps to authenticate the app...

You can read more about it on their documentation here

Copy link
Contributor

@jobala jobala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are using placeholder ids instead of real ids.

@ElinorW ElinorW marked this pull request as ready for review April 16, 2021 11:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-923.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-923.centralus.azurestaticapps.net

@thewahome thewahome self-requested a review June 7, 2021 17:31
Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElinorW ElinorW merged commit 776efaf into dev Jun 8, 2021
thewahome added a commit that referenced this pull request Jun 8, 2021
* Task: Add Cred Scan (#937)

* Task: telemetry capture English theme names only (#958)

* Feature: add telemetry middleware (#961)

* Task: Capture deployed version of application for all telemetry data collected (#964)

* Task: Enable autocollection of unhandled exceptions (#963)

* Fix: prevent running empty requests (#972)

* Task: add code-owners (#969)

* Task: send notification when release is created (#967)

* Fix: interaction in progress (#976)

* Feature: Display Graph Explorer Version (#977)

* Feature: show delta links when property is present (#978)

* Feature: Intergrate OCV feedback  (#923)

* Fix: mgt story links (#981)

* Task: Update README.md for Azure auth steps (#982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback button
4 participants