Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Response area container heights #2372

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Fix: Response area container heights #2372

merged 4 commits into from
Feb 1, 2023

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Feb 1, 2023

Overview

Fixes #2066
The page doesn't move around as much when selecting response area tabs

Testing Instructions

  • Load GE on your local environment
  • Select and Run any sample query e.g GET /me
  • Select different Response Area Tabs
  • Observe consistent height when there is data
  • Observe consistent height when no data is present

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2372.centralus.azurestaticapps.net

@ElinorW ElinorW merged commit eeca0fb into dev Feb 1, 2023
@ElinorW ElinorW deleted the fix/response-area-height branch February 1, 2023 19:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot mentioned this pull request Feb 8, 2023
thewahome pushed a commit that referenced this pull request Feb 13, 2023
Feature: add general playwright tests (#2149)

Task: Add Graph Support Info on README.md (#2347)

Task: Add logging for script errors (#2351)

Task: Add language snippet telemetry (#2371)

Task: Rename sample query "all the items in my drive" to "list items in my drive" (#2350)

Fix: Response area container heights (#2372)

Fix: Re-order tests (#2354)

Fix: Inform user if URL is incomplete (#2367)

Fix: Autocollapsing of history items (#2331)

Fix: Screen blanking on render (#2403)

Fix: Add method to filter ResizeObserver exceptions (#2342)

Fix: enter key runs previous query (#2348)

Fix: autocomplete character selection (#2304)

Fix: Display beta resources subgroups for admin group (#2364)

Fix: Update deprecated aria-label (#2368)

Fix: Default overlay on collections review panel (#2377)

Chore: December dependabot upgrades (#2296)

Chore: Dependabot upgrades February (#2401)

chore: Dependabot upgrades (#2335)

Chore: Code cleanup (#2251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response area has varying heights based on the pivot you select
3 participants