Fix: enter key runs previous query #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onokaev
reviewed
Jan 17, 2023
| @@ -58,6 +58,7 @@ const AutoComplete = (props: IAutoCompleteProps) => { | |||
| const targetValue = e.target.value; | |||
| setQueryUrl(targetValue); | |||
| props.contentChanged(targetValue); | |||
| console.log(targetValue) | |||
There was a problem hiding this comment.
Must have forgotten this :)
Onokaev
approved these changes
Jan 17, 2023
ElinorW
approved these changes
Jan 18, 2023
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2348.centralus.azurestaticapps.net |
Merged
thewahome
pushed a commit
that referenced
this pull request
Feb 13, 2023
Feature: add general playwright tests (#2149) Task: Add Graph Support Info on README.md (#2347) Task: Add logging for script errors (#2351) Task: Add language snippet telemetry (#2371) Task: Rename sample query "all the items in my drive" to "list items in my drive" (#2350) Fix: Response area container heights (#2372) Fix: Re-order tests (#2354) Fix: Inform user if URL is incomplete (#2367) Fix: Autocollapsing of history items (#2331) Fix: Screen blanking on render (#2403) Fix: Add method to filter ResizeObserver exceptions (#2342) Fix: enter key runs previous query (#2348) Fix: autocomplete character selection (#2304) Fix: Display beta resources subgroups for admin group (#2364) Fix: Update deprecated aria-label (#2368) Fix: Default overlay on collections review panel (#2377) Chore: December dependabot upgrades (#2296) Chore: Dependabot upgrades February (#2401) chore: Dependabot upgrades (#2335) Chore: Code cleanup (#2251)
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #2338
Notes
It fails for the use case where a user types in something and it is the only thing in the suggestions. Since we didn't assume this becomes the selected suggestion, the query doesn't get changed.
It is fixed by appending the suggestion to the URL
Testing Instructions
/memetousers/usersin the response