Fix: change hover scroll behaviour #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewahome
requested review from
adhiambovivian,
ddyett,
ElinorW and
millicentachieng
as code owners
thewahome
changed the title
ElinorW
requested changes
Aug 3, 2021
| onItemInvoked={this.querySelected} | ||
| /> | ||
| </div> | ||
| <DetailsList |
There was a problem hiding this comment.
We need the div with the navigation role for accessibility purposes
ElinorW
approved these changes
Aug 3, 2021
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1043.centralus.azurestaticapps.net |
thewahome
added a commit
that referenced
this pull request
Aug 3, 2021
* Task: Add chat-id & membership-id (#1024) * Fix: query link parsing with trailing '.' (#1033) * Feature: DetailsList scrollbars only appear onHover (#1023) * Feature: automatic dark light mode (#1019) * Task: add translated aria labels (#1040) * Task: remove sandbox api test (#1042) * Fix: change hover scroll behaviour (#1043) * Fix: Accessibility bugs - Aug (#1041) * Feature: Add Expanding Query Input Field (#1020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enhances #1023 to use CSS instead of javascript functions to show the hover