Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat-id & membership-id #1024

Merged

Conversation

ayubun
Copy link
Contributor

@ayubun ayubun commented Jul 15, 2021

The tokens added in this PR are used in our soon-to-be proposed sample queries for Teams chats. This PR will need to be merged before we can merge any sample queries into the https://github.com/microsoftgraph/microsoft-graph-devx-content repository; Otherwise, the sample queries will not work because they cannot populate the required tokens in sandbox mode.

The chat-id used is the first chat returned when using the GET https://graph.microsoft.com/beta/me/chats/ query in sandbox mode, and the membership-id used is the first chat member id returned when using the GET https://graph.microsoft.com/beta/me/chats/{chat-id}/members/ query in sandbox mode.

All of the newly committed IDs have been tested on localhost.

Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thewahome thewahome merged commit cb12239 into microsoftgraph:dev Jul 23, 2021
thewahome added a commit that referenced this pull request Aug 3, 2021
* Task: Add chat-id & membership-id (#1024)

* Fix: query link parsing with trailing '.' (#1033)

* Feature: DetailsList scrollbars only appear onHover (#1023)

* Feature: automatic dark light mode (#1019)

* Task: add translated aria labels (#1040)

* Task: remove sandbox api test (#1042)

* Fix: change hover scroll behaviour (#1043)

* Fix: Accessibility bugs - Aug  (#1041)

* Feature: Add Expanding Query Input Field (#1020)
@lhao03 lhao03 deleted the interns/AyuAi/new-sample-query-tokens branch August 11, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants