Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Default overlay on collections review panel #2377

Merged
merged 12 commits into from
Feb 7, 2023
Merged

Fix: Default overlay on collections review panel #2377

merged 12 commits into from
Feb 7, 2023

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Feb 1, 2023

Overview

Closes #2376

Demo

Optional. Screenshots, curl examples, etc.

Notes

The update can be seen on the playwright snapshot diff

Testing Instructions

  • How to test this PR
    CLick on the Resources tab
    Click on any kebab menu then select Add to collections
    Click on Preview collections
    Notice the fix

@Onokaev Onokaev requested a review from thewahome February 2, 2023 12:35
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

thewahome
thewahome previously approved these changes Feb 7, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

@ElinorW ElinorW requested review from ElinorW and removed request for MaryannGitonga February 7, 2023 09:13
@Onokaev Onokaev requested a review from thewahome February 7, 2023 09:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

ElinorW
ElinorW previously approved these changes Feb 7, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

@Onokaev Onokaev requested a review from ElinorW February 7, 2023 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2377.centralus.azurestaticapps.net

@thewahome thewahome merged commit bd5da68 into dev Feb 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome deleted the fix/paths-review-overlay branch February 8, 2023 08:35
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Merged
thewahome pushed a commit that referenced this pull request Feb 13, 2023
@github-actions
Chore: Release 7.2.0 (#2414)
a6bd177 
Feature: add general playwright tests (#2149)

Task: Add Graph Support Info on README.md (#2347)

Task: Add logging for script errors (#2351)

Task: Add language snippet telemetry (#2371)

Task: Rename sample query "all the items in my drive" to "list items in my drive" (#2350)

Fix: Response area container heights (#2372)

Fix: Re-order tests (#2354)

Fix: Inform user if URL is incomplete (#2367)

Fix: Autocollapsing of history items (#2331)

Fix: Screen blanking on render (#2403)

Fix: Add method to filter ResizeObserver exceptions (#2342)

Fix: enter key runs previous query (#2348)

Fix: autocomplete character selection (#2304)

Fix: Display beta resources subgroups for admin group (#2364)

Fix: Update deprecated aria-label (#2368)

Fix: Default overlay on collections review panel (#2377)

Chore: December dependabot upgrades (#2296)

Chore: Dependabot upgrades February (#2401)

chore: Dependabot upgrades (#2335)

Chore: Code cleanup (#2251)
This was referenced Sep 25, 2024
Closed
Closed
Merged
@release-please release-please bot mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome Awaiting requested review from thewahome

@ElinorW ElinorW Awaiting requested review from ElinorW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Preview Collections tab overlays the entire screen with a white background
3 participants
@Onokaev @ElinorW @thewahome