Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inform user if URL is incomplete #2367

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Jan 31, 2023

Overview

Closes #2359

Demo

image

Notes

The ABNF validator only validates URLs that have the http/https protocol appended. We therefore need extra validation when the abnf validator is not returning an error.

Testing Instructions

  • How to test this PR
    Backspace on the query URL until there's only http left
    See fix

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

@Onokaev Onokaev requested a review from ElinorW January 31, 2023 17:55
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

2 similar comments
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2367.centralus.azurestaticapps.net

@Onokaev Onokaev merged commit bf24ee1 into dev Feb 7, 2023
@Onokaev Onokaev deleted the fix/running-incomplete-queries branch February 7, 2023 09:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot mentioned this pull request Feb 8, 2023
thewahome pushed a commit that referenced this pull request Feb 13, 2023
Feature: add general playwright tests (#2149)

Task: Add Graph Support Info on README.md (#2347)

Task: Add logging for script errors (#2351)

Task: Add language snippet telemetry (#2371)

Task: Rename sample query "all the items in my drive" to "list items in my drive" (#2350)

Fix: Response area container heights (#2372)

Fix: Re-order tests (#2354)

Fix: Inform user if URL is incomplete (#2367)

Fix: Autocollapsing of history items (#2331)

Fix: Screen blanking on render (#2403)

Fix: Add method to filter ResizeObserver exceptions (#2342)

Fix: enter key runs previous query (#2348)

Fix: autocomplete character selection (#2304)

Fix: Display beta resources subgroups for admin group (#2364)

Fix: Update deprecated aria-label (#2368)

Fix: Default overlay on collections review panel (#2377)

Chore: December dependabot upgrades (#2296)

Chore: Dependabot upgrades February (#2401)

chore: Dependabot upgrades (#2335)

Chore: Code cleanup (#2251)
This was referenced Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants