Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds go to the snippet tabs #1189

Merged
merged 4 commits into from
Nov 17, 2021
Merged

adds go to the snippet tabs #1189

merged 4 commits into from
Nov 17, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Nov 4, 2021

Overview

Adds Go as a snippet tab

Demo

image

Notes

Related microsoftgraph/microsoft-graph-devx-api#749

I put go last as it's in preview, but if you prefer an alphabetical order, we can move it before objective-C

Testing Instructions

  • Run devx API locally (or wait for the other PR to be merged and released)
  • Update DEVX_API_URL to your local url. (optional, only if running devx API locally)
  • npm run start
  • open the brower to the server url
  • click on Code snippets
  • click on Go

@thewahome
Copy link
Collaborator

@baywet Good work on the tab.
The code snippets seem not to be supported. The calls fail with this message.
Message: "Specified argument was out of the range of valid values. (Parameter 'Language 'go' is not supported')" StatusCode: 404

@baywet
Copy link
Member Author

baywet commented Nov 5, 2021

@thewahome that's because as indicated by my initial comment it depends on microsoftgraph/microsoft-graph-devx-api#749

Were you running that branch of the devx Api locally when you tested it?

@thewahome
Copy link
Collaborator

@thewahome that's because as indicated by my initial comment it depends on microsoftgraph/microsoft-graph-devx-api#749

Were you running that branch of the devx Api locally when you tested it?

No @baywet . Doing this soon.

@adhiambovivian @kristen-msft How do we get word out that there will be 'Go' support? This work should not go in without hullabaloo :-)

@baywet
Copy link
Member Author

baywet commented Nov 17, 2021

FYI now that the devx PR made it to production I did another round of validation thanks to the help of @ElinorW
this is what it looks like, without having to change the API URL anymore.

image

@ElinorW ElinorW merged commit 4fa3639 into microsoftgraph:dev Nov 17, 2021
@baywet baywet deleted the feature/go-snippets branch November 17, 2021 20:53
@baywet
Copy link
Member Author

baywet commented Nov 17, 2021

thanks for merging team! please let me know when it's deployed :)

ElinorW added a commit that referenced this pull request Nov 18, 2021
* HB of localized GE.jsons (#1094)

* Capture telemetry for Graph Proxy API calls (#1098)

* Capture GE mode for all telemetry items (#1105)

* Update how we are sanitizing track trace to include more info (#1122)

* Capture telemetry for graph toolkit example link (#1125)

* chore: handover-translations (#1107)

* Feature: input hints (#1104)

* Enhancement: Make pivots headers responsive (#1121)

* Chore: add linter workflow (#1132)

* Fix: linting errors (#1133)

* Fix: Request headers textfield bug (#1137)

* Fix: Update packages (#1138)

* Fix: makes query color in the text area black (#1152)

* Fix: CORS workaround to enable downloading of content (#1032)

* Fix: Accessibility error for 'button-name' (#1164)

* Fix: move documentation links to the first column (#1158)

* Fix: Add focus on button (#1153)

* Fix: Create user when emailAddress is unavailable (#1165)

* Chore: add dependabot configuration (#1188)

* Fix: try it interaction (#1185)

* Fix: failing nextlink call (#1184)

* Fix: request and response height (#1201)

* Fix: Remove hover functions on history tab (#1204)

* Feature: Add feedback button and pop-up (#1183)

* Fix: Update GitHub workflow (#962)

* Fix: Concept try-it button (#966)

* Fix: prevent running empty requests (#965)

* Task: add description to documentation link (#1203)

* Chore: translate to German (#1208)

* validate index of selected query (#1210)

* Translate to portuguese (#1212)

* Chore: Handover translations (#1213)

* Chore(deps): Bump @babel/eslint-parser from 7.12.13 to 7.16.3 (#1207)

* Feature: adds go to the snippet tabs (#1189)

* Chore: (Dependabot) Update packages (#1220)

* Chore(deps): Bump jest-watch-typeahead from 0.2.1 to 0.5.0 (#1199)

* Chore(deps): Bump @axe-core/webdriverjs from 4.2.2 to 4.3.1 (#1192)

* Chore(deps-dev): Bump react-test-renderer from 16.8.3 to 16.13.0 (#1195)

* Chore(deps): Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3 (#1198)

* Chore(deps): Bump re-resizable from 6.9.0 to 6.9.1 (#1197)

* Chore(deps): Bump terser-webpack-plugin from 3.1.0 to 4.2.3 (#1196)

* Chore(deps): Bump file-loader from 2.0.0 to 6.2.0 (#1194)

* Chore(deps-dev): Bump @types/react from 16.8.3 to 17.0.35 (#1219)

* Chore(deps): Bump react from 16.8.2 to 16.14.0 (#1193)

* Fix: Linting errors in snippets (#1233)

* Fix: Failure to load on Safari (Mac) (#1222)

* chore(release): 4.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants