Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture GE mode for all telemetry items #1105

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

millicentachieng
Copy link
Contributor

Overview

Capture GE mode for all telemetry items sent to Application Insights.

This is to help us properly distinguish between Try It and main GE telemetry.

Demo

Load Graph Explorer and click on the Run query button while on the network tab of developer tools.

Copy link
Collaborator

@thewahome thewahome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Also, since we now have access to the state in the filter, can we clean up the other telemetry instrumentations that submit state info and collect state info in the filters instead?

@millicentachieng
Copy link
Contributor Author

Good stuff!

Also, since we now have access to the state in the filter, can we clean up the other telemetry instrumentations that submit state info and collect state info in the filters instead?

I'll explore that, @thewahome.

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-1105.centralus.azurestaticapps.net

@millicentachieng millicentachieng merged commit 0920ab5 into dev Sep 15, 2021
@millicentachieng millicentachieng deleted the task/capture-ge-mode-for-all-telemetry-data branch September 15, 2021 11:40
ElinorW added a commit that referenced this pull request Nov 18, 2021
* HB of localized GE.jsons (#1094)

* Capture telemetry for Graph Proxy API calls (#1098)

* Capture GE mode for all telemetry items (#1105)

* Update how we are sanitizing track trace to include more info (#1122)

* Capture telemetry for graph toolkit example link (#1125)

* chore: handover-translations (#1107)

* Feature: input hints (#1104)

* Enhancement: Make pivots headers responsive (#1121)

* Chore: add linter workflow (#1132)

* Fix: linting errors (#1133)

* Fix: Request headers textfield bug (#1137)

* Fix: Update packages (#1138)

* Fix: makes query color in the text area black (#1152)

* Fix: CORS workaround to enable downloading of content (#1032)

* Fix: Accessibility error for 'button-name' (#1164)

* Fix: move documentation links to the first column (#1158)

* Fix: Add focus on button (#1153)

* Fix: Create user when emailAddress is unavailable (#1165)

* Chore: add dependabot configuration (#1188)

* Fix: try it interaction (#1185)

* Fix: failing nextlink call (#1184)

* Fix: request and response height (#1201)

* Fix: Remove hover functions on history tab (#1204)

* Feature: Add feedback button and pop-up (#1183)

* Fix: Update GitHub workflow (#962)

* Fix: Concept try-it button (#966)

* Fix: prevent running empty requests (#965)

* Task: add description to documentation link (#1203)

* Chore: translate to German (#1208)

* validate index of selected query (#1210)

* Translate to portuguese (#1212)

* Chore: Handover translations (#1213)

* Chore(deps): Bump @babel/eslint-parser from 7.12.13 to 7.16.3 (#1207)

* Feature: adds go to the snippet tabs (#1189)

* Chore: (Dependabot) Update packages (#1220)

* Chore(deps): Bump jest-watch-typeahead from 0.2.1 to 0.5.0 (#1199)

* Chore(deps): Bump @axe-core/webdriverjs from 4.2.2 to 4.3.1 (#1192)

* Chore(deps-dev): Bump react-test-renderer from 16.8.3 to 16.13.0 (#1195)

* Chore(deps): Bump eslint-plugin-flowtype from 2.50.1 to 2.50.3 (#1198)

* Chore(deps): Bump re-resizable from 6.9.0 to 6.9.1 (#1197)

* Chore(deps): Bump terser-webpack-plugin from 3.1.0 to 4.2.3 (#1196)

* Chore(deps): Bump file-loader from 2.0.0 to 6.2.0 (#1194)

* Chore(deps-dev): Bump @types/react from 16.8.3 to 17.0.35 (#1219)

* Chore(deps): Bump react from 16.8.2 to 16.14.0 (#1193)

* Fix: Linting errors in snippets (#1233)

* Fix: Failure to load on Safari (Mac) (#1222)

* chore(release): 4.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants