Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adds support for go snippets generation #749

Merged
merged 21 commits into from
Nov 15, 2021
Merged

Conversation

baywet
Copy link
Member

@baywet baywet commented Nov 2, 2021

Overview

Adds snippets generation for Go OData/Kiota

Testing Instructions

POST /api/snippets?generation=openapi&lang=go
--BODY---
GET /v1.0/me HTTP/1.1
Host: graph.microsoft.com
Content-Type: application/json

Results in the new open api & kiota based generation with

//THE GO SDK IS IN PREVIEW. NON-PRODUCTION USE ONLY
graphClient := msgraphsdk.NewGraphClient(requestAdapter);

result, err := graphClient.Me().Get(nil);

@baywet baywet self-assigned this Nov 2, 2021
@baywet baywet marked this pull request as ready for review November 4, 2021 16:29
@baywet baywet enabled auto-merge November 4, 2021 16:29
@baywet baywet force-pushed the feature/go-snippet-openapi branch from c700fb1 to 559b2d6 Compare November 4, 2021 16:30
…ration

- fixes a bug where empty collections could derail go snippets generation

Signed-off-by: Vincent Biret <[email protected]>
- fixes a bug where go snippets generation would fail on path casing
- fixes a bug where go snippets generation would fail on odata filter functions

Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet requested a review from andrueastman November 15, 2021 14:48
baywet and others added 2 commits November 15, 2021 06:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.8% 82.8% Coverage
0.0% 0.0% Duplication

@baywet baywet disabled auto-merge November 15, 2021 15:33
@baywet baywet merged commit 92ca8f8 into dev Nov 15, 2021
@baywet baywet deleted the feature/go-snippet-openapi branch November 15, 2021 15:33
baywet added a commit that referenced this pull request Nov 15, 2021
- adds support for go snippets generation (#749) to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants