Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adds go 1.20 #95835

Merged
Merged

Conversation

baywet
Copy link
Member

@baywet baywet commented Feb 7, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @wingetbot,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. Retry-1 flag to indicate retried labels Feb 7, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 8, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@denelon denelon removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Retry-1 flag to indicate retried Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 8, 2023
@baywet
Copy link
Member Author

baywet commented Feb 9, 2023

@denelon now that the validation is completed, can somebody review and merge it please?

vedantmgoyal9
vedantmgoyal9 previously approved these changes Feb 9, 2023
Trenly
Trenly previously approved these changes Feb 9, 2023
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the 3-field version is used in control panel. I'm going to approve this since it Shouldnt cause any issues, as all versions are assumed to have infinite trailing zeros, so 1.20 and 1.20.0 are functionally equivalent, but for future releases the 3-field version (e.g 1.20.1) will probably be required, and may require this manifest to be updated later

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello microsoft-github-policy-service[bot],
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello wingetbot,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot wingetbot added the Validation-Completed Validation passed label Feb 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

wingetbot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello microsoft-github-policy-service[bot],
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f9d1b89 into microsoft:master Feb 10, 2023
@baywet baywet deleted the feature/go-1-20 branch February 10, 2023 19:09
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This was referenced Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants