Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Expected Minimum Go Version to 1.19 #377

Closed
1 task done
bendbennett opened this issue Mar 3, 2023 · 5 comments · Fixed by #378
Closed
1 task done

Bump Expected Minimum Go Version to 1.19 #377

bendbennett opened this issue Mar 3, 2023 · 5 comments · Fixed by #378
Labels
dependencies go Pull requests that update Go code
Milestone

Comments

@bendbennett
Copy link
Contributor

Terraform CLI and Provider Versions

random v3.4.3

Use Cases or Problem Statement

Following the Go support policy and given the ecosystem availability of the latest Go minor version, it's time to upgrade. This will ensure that this project can use recent improvements to the Go runtime, standard library functionality, and continue to receive security updates

Proposal

  • Run the following commands to upgrade the Go module files and automatically fix outdated Go code:
go mod edit -go=1.19
go mod tidy
go fix ./...
  • Ensure any GitHub Actions workflows (.github/workflows/*.yml) use 1.20 in place of any 1.19 and 1.19 in place of any 1.18 or earlier
  • Ensure the README or any Contributing documentation notes the Go 1.19 expected minimum
  • (Not applicable to all projects) Ensure the .go-version is at least 1.19 or later

How much impact is this issue causing?

Low

Additional Information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bendbennett bendbennett added dependencies go Pull requests that update Go code labels Mar 3, 2023
@bendbennett bendbennett added this to the v3.5.0 milestone Mar 3, 2023
bendbennett added a commit that referenced this issue Mar 3, 2023
bendbennett added a commit that referenced this issue Mar 6, 2023
@faarshad
Copy link

faarshad commented Mar 7, 2023

Hi @bendbennett, thank you for fixing this. I see #378 is merged to main but any idea on when this would be released?

It will fix all these security bugs:
1 CVE-2022-32190|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.18.6|7.5|high
2 CVE-2022-27664|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.19.1, 1.18.6|7.5|high
3 CVE-2022-2879|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.19.2, 1.18.7|7.5|high
4 CVE-2022-2880|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.19.2, 1.18.7|7.5|high
5 CVE-2022-41715|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.19.2, 1.18.7|7.5|high
6 CVE-2022-41716|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.19.3, 1.18.8|5.4|medium
7 CVE-2022-41717|go|.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.4.3/linux_amd64/terraform-provider-random_v3.4.3_x5|1.18.5|fixed in 1.19.4, 1.18.9|5.3|medium

@azuterios
Copy link

@bendbennett Thank you for the Fix! Do you know a possible timeframe on a new release of the provider?

@bendbennett
Copy link
Contributor Author

Hi @faarshad @azuterios 👋

The update to Go 1.19 has been released as v3.5.0.

@azuterios
Copy link

azuterios commented Apr 12, 2023

Hi @faarshad @azuterios 👋

The update to Go 1.19 has been released as v3.5.0.

@bendbennett Thank you for the prompt response and quick release!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants