Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zip][Portable] New package: thebookisclosed.ViVeTool version 0.3.2 #92418

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented Dec 28, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 28, 2022
@ghost
Copy link

ghost commented Dec 28, 2022

Hello @SpecterShell,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 28, 2022
@stephengillie stephengillie self-assigned this Dec 28, 2022
@stephengillie
Copy link
Collaborator

In a VM, it installed successfully, and ran with no arguments. But both the /query and /enable arguments gave the same error:

PS C:\> C:\Users\user\AppData\Local\Microsoft\WinGet\Links\vivetool.exe /query
ViVeTool v0.3.2 - Windows feature configuration tool


Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'Albacore.ViVe, Version=2022.6.27.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
   at Albacore.ViVeTool.Program.ProcessArgs(String[] args)
   at Albacore.ViVeTool.Program.Main(String[] args)

Is there a missing dependency?

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 28, 2022
@SpecterShell
Copy link
Contributor Author

In a VM, it installed successfully, and ran with no arguments. But both the /query and /enable arguments gave the same error:

PS C:\> C:\Users\user\AppData\Local\Microsoft\WinGet\Links\vivetool.exe /query
ViVeTool v0.3.2 - Windows feature configuration tool


Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'Albacore.ViVe, Version=2022.6.27.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
   at Albacore.ViVeTool.Program.ProcessArgs(String[] args)
   at Albacore.ViVeTool.Program.Main(String[] args)

Is there a missing dependency?

I guess it is the Albacore.ViVe.dll file in the same directory. I manually copied the remaining files to the Links folder and it works fine now.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 29, 2022
@SpecterShell SpecterShell marked this pull request as draft December 29, 2022 03:29
@thebookisclosed
Copy link

thebookisclosed commented Jan 27, 2023

Hi, actual ViVeTool developer here.
Can this PR please get rejected?
I was never made aware of it and only found it today thanks to users mentioning it in my issue tracker. I find submissions of someone else's tools without any form of approval a bit unprofessional.

@denelon
Copy link
Contributor

denelon commented Jan 27, 2023

@thebookisclosed,

I looked at:

I don't believe there was any ill will intended here. There are thousands of open-source packages in the community repository here and many are maintained by parties other than the original author. The actual packages aren't being copied over. The PR is to generate a manifest so WinGet could be used to install the package. Ideally, authors would publish manifests with their releases directly, but in many cases, they aren't able due to resource constraints or knowledge.

If you are interested in publishing the package yourself in the future, there are examples of how to do so using GitHub actions and we provide wingetcreate as a tool to support CI/CD scenarios:

@denelon denelon closed this Jan 27, 2023
@thebookisclosed
Copy link

thebookisclosed commented Jan 27, 2023

@denelon
Thank you for closing the PR. I'm sorry if the request sounded a bit brash, it was just a bit weird to see this submission without having the creator at least ask for permission. ViVe is of course open source and the manifest did correctly link to a GitHub release instead of another unofficial mirror, thing is I'd prefer to have some oversight when it comes to publishing it to WinGet. Thank you for understanding.

Thank you very much for the CI/CD pointers, I am interested in eventually pushing to WinGet but there are some quirks I'd like to iron out first.

@sitiom
Copy link
Contributor

sitiom commented Jan 28, 2023

@denelon
Thank you for closing the PR. I'm sorry if the request sounded a bit brash, it was just a bit weird to see this submission without having the creator at least ask for permission.

It was within his right to do so (at least that's what the license allows).

ViVe is of course open source and the manifest did correctly link to a GitHub release instead of another unofficial mirror

winget-pkgs does not allow software from unofficial sources.

Thank you very much for the CI/CD pointers, I am interested in eventually pushing to WinGet but there are some quirks I'd like to iron out first.

I do not think you will be able to do this until the symlink dependency problem is resolved in Winget (which was the only problem in this manifest):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants