Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Google.Android.SDKPlatformTools version 33.0.3 #94818

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jan 27, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sitiom sitiom marked this pull request as draft January 27, 2023 16:00
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Hello @sitiom,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 27, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 28, 2023

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Feb 6, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 3, 2023
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. zip-binary Depends on library files that aren't available via symlink labels Aug 3, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @sitiom,

This package appears to depend on .dlls that aren't available via symlink.

This PR is blocked until support for zipped binaries is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/zipBinary

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 3, 2023
@Trenly
Copy link
Contributor

Trenly commented Dec 3, 2024

@sitiom - Support for zipped binaries has now been added and is available in the pipelines. This will require you to update your submission to ManifestVersion: 1.9.0 and set ArchiveBinariesDependOnPath: true in the installer node. To keep things clean, this PR is being closed. Please submit a new PR for the latest version of this package. Thank you for your contributions!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 3, 2024
@sitiom
Copy link
Contributor Author

sitiom commented Dec 4, 2024

Continued in #190804

@sitiom sitiom deleted the Google.Android.SDKPlatformTools-33.0.3-4E05E834C751B3 branch December 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Executable-Error Waived-Validation-Executable-Error zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android SDK Platform-Tools
7 participants