Add support for proxies #190 #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/AppInstallerCLICore/ExecutionContextData.h # src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw
yao-msft
reviewed
Mar 8, 2024
| switch (setting) | ||
| { | ||
| case AppInstaller::Settings::StringAdminSetting::DefaultProxy: | ||
| return GroupPolicies().GetValueRef<ValuePolicy::DefaultProxy>(); |
There was a problem hiding this comment.
Just double check, if DefaultProxy group policy is not set. The return will be std::nullopt? Why there's a reference_wrapper needed here?
There was a problem hiding this comment.
Yes, GroupPolicies().GetValue*() returns std::nullopt if the policy is not set.
Unless I'm misunderstanding what it does, the reference_wrapper allows us to return a reference of the value instead of copying it. That is the behavior I would expect if we were able to do std::optional<std::string&>.
yao-msft
reviewed
Mar 14, 2024
Co-authored-by: yao-msft <[email protected]>
Co-authored-by: yao-msft <[email protected]>
yao-msft
approved these changes
Mar 14, 2024
This was referenced Aug 15, 2024
|
I'm very sorry that my issues and PRs are causing problems for you all. Thanks to microsoft and the winget team for their excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #190
See spec on #4152
See #1776 for a related PR for the feature with the core implementation for proxies in wininet
This PR adds basic support for using proxies. Most of the changes are for enabling the configuration and blocking of the feature. This feature will be gated behind an experimental feature setting
AdminSettingsto support settings with string values, instead of only bool flags. The implementation is mostly a copy of the bool case. In the future we should look back at it to reduce duplication of code.setsubcommand tosettingsthat can set the admin settingsManually tested on a VM using mitmproxy
Pending: Adding automated tests tests.
Microsoft Reviewers: Open in CodeFlow