Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix German localization resource file, especially many odd translations regarding packages and pinning #4133

Closed

Conversation

igorakkerman
Copy link

@igorakkerman igorakkerman commented Feb 1, 2024


Fixes #3966

Microsoft Reviewers: Open in CodeFlow

@igorakkerman igorakkerman requested a review from a team as a code owner February 1, 2024 23:30
@igorakkerman
Copy link
Author

@microsoft-github-policy-service agree

@Trenly
Copy link
Contributor

Trenly commented Feb 1, 2024

Files under Localization folder will be overwritten when we do a localization update, so no changes under Localization folder will take effect.
Originally posted by @yao-msft in #3250 (comment)

Someone at MSFT will need to submit these to the internal localization team

@yao-msft
Copy link
Contributor

yao-msft commented Feb 2, 2024

Thanks for your suggestion, @igorakkerman

For winget team: I have created bug BUG 48808197 for localization team consideration.

We'll close the bug after localization team takes in the suggestions, and after winget's next localization refresh.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Area-Localization Issues related to localization label Feb 6, 2024
@denelon
Copy link
Contributor

denelon commented Jul 11, 2024

The latest localization patches were included in WinGet 1.8. I'm going to go ahead and close this PR.

@denelon denelon closed this Jul 11, 2024
@igorakkerman
Copy link
Author

igorakkerman commented Jul 13, 2024

@denelon I don't see any of the changes from this PR in the latest resource file. Is it safe to assume that they were rejected by your localization team in your internal review process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization Issues related to localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong translation en: targeting de: Zielgruppenadressierung
4 participants