Fix spelling mistake in german #3250
Conversation
|
Looks like this issue exists in all other localized languages strings. Filed localization bug internally. |
| @@ -702,7 +702,7 @@ Sie können über die Einstellungsdatei „winget settings“ konfiguriert werde | |||
| <value>Zeigt verfügbare Upgrades an und führt sie aus.</value> | |||
| </data> | |||
| <data name="Usage" xml:space="preserve"> | |||
| <value>Verwendung: {0}{1}</value> | |||
| <value>Verwendung: {0} {1}</value> | |||
| <comment>{Locked="{0}","{1}"} Message displayed to provide the user with instructions on how to use a command. {0} is a placeholder replaced by the program name (e.g. 'winget'). {1} is a placeholder replaced by the pattern for using the selected command.</comment> | |||
There was a problem hiding this comment.
Actually. this issue could be fixed by updating locked words in comments in this file here
to be {Locked="{0} {1}"}
@speedfighter, would you make that change since you found this issue? Or I can make that change if you are not comfortable making it.
There was a problem hiding this comment.
I can make these changes when I'm at home.
|
I have implemented the changes. I hope I understood you correctly. |
Or do I need to revert the changes made in my first commit? |
Hi @speedfighter, I'm sorry I should make my comments more clear. All localization changes need to go to en-US file at src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw Files under Localization folder will be overwritten when we do a localization update, so no changes under Localization folder will take effect. Also please only lock the 3 places I mentioned at line 714, 845 and 1019 in en-US file. Thanks |
| @@ -872,7 +872,7 @@ Sie können über die Einstellungsdatei „winget settings“ konfiguriert werde | |||
| </data> | |||
| <data name="InvalidArgumentValueError" xml:space="preserve"> | |||
| <value>Der für das Argument "{0}" angegebene Wert ist ungültig. gültige Werte sind: {1}</value> | |||
| <comment>{Locked="{0}","{1}"} Error message displayed when the user provides an invalid command line argument value. {0} is a placeholder replaced by the argument name. {1} is a placeholder replaced by a list of valid options.</comment> | |||
| <comment>{Locked="{0} {1}"} Error message displayed when the user provides an invalid command line argument value. {0} is a placeholder replaced by the argument name. {1} is a placeholder replaced by a list of valid options.</comment> | |||
There was a problem hiding this comment.
This change is not needed as {0} and {1} are separate
|
Sorry. I don't saw that your lines was in the en-US file. |
Thanks for the contribution! |
The spelling mistake on the screenshot will be fixed with this pull request.
There was a missing space.
Microsoft Reviewers: Open in CodeFlow