-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 1.2 Schema Additions #2028
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not leaving some of these comments regarding number of nodes and the enum in the original PR (#1996)
schemas/JSON/manifests/v1.2.0/manifest.defaultLocale.1.2.0.json
Outdated
Show resolved
Hide resolved
schemas/JSON/manifests/v1.2.0/manifest.defaultLocale.1.2.0.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the documentations a bit more, it seems that with the proposed schema, the Documentations (if not null) could be an empty array, or an array of empty objects.
I also think that we should force quality here, and require that each Documentation require the URL and Description, as a documentation without a URL is meaningless and a URL without a description may be confusing
This comment was marked as resolved.
This comment was marked as resolved.
src/AppInstallerRepositoryCore/Rest/Schema/1_1/Json/ManifestDeserializer_1_1.cpp
Outdated
Show resolved
Hide resolved
I discussed with the team and I decided to not follow through with these changes. There are a lot of components such as WingetCreate, WingetSvc, and other 3rd parties that rely on the schema and adding more constraints could be breaking. These changes will require more thorough testing that I won't address in this PR, so I will stick with the existing pattern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates the 1.2 schema to incorporate the proposed changes from #1891. This only adds functionality for parsing and processing the new schema additions and does not include their respective feature support.
Also includes additional proposed arguments and settings schema changes for installing portables. Excludes some of the installer manifest changes for the portable feature as those will be included with the work for the portable install feature which will have more thorough testing.
Related to:
Microsoft Reviewers: Open in CodeFlow