Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87456: Configuration to increase the terminal cursor width #87911

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

BuraChuhadar
Copy link
Contributor

This PR fixes #87456

This PR would set terminal bar cursor width.

@ghost
Copy link

ghost commented Dec 31, 2019

Thank You @BuraChuhadar.

I think it will be nice if the option is called as cursorWidth to stay consistent with the editor.cursorWidth option and xterm's internal cursorWidth option.

Besides that, src/vs/editor/common/config/editorOptions.ts explicitly mentions when this option will be effective (i.e when cursorStyle is "line"):

cursorWidth: register(new EditorIntOption(
    EditorOption.cursorWidth, 'cursorWidth',
    0, 0, Constants.MAX_SAFE_SMALL_INTEGER,
    { markdownDescription: nls.localize('cursorWidth', "Controls the width of the cursor when `#editor.cursorStyle#` is set to `line`.") }
)),

So to keep it consistent, the help text in the code src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts can be made:

markdownDescription: nls.localize('terminal.integrated.cursorWidth', "Controls the width of terminal cursor when `#terminal.integrated.cursorStyle#` is set to `line`.")

Let me know if I need to do it as an extra commit!

@BuraChuhadar
Copy link
Contributor Author

@varmanishant added the changes you asked. Let me know if you have other feedback.

@ghost
Copy link

ghost commented Dec 31, 2019

Appreciate, @BuraChuhadar .

@Tyriar Tyriar added this to the January 2020 milestone Dec 31, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with updated xterm and it works great, thanks!

@Tyriar Tyriar merged commit ff00bad into microsoft:master Dec 31, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration to increase the terminal cursor width
2 participants