Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration to increase the terminal cursor width #87456

Closed
ghost opened this issue Dec 20, 2019 · 2 comments · Fixed by #87911
Closed

Configuration to increase the terminal cursor width #87456

ghost opened this issue Dec 20, 2019 · 2 comments · Fixed by #87911
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label
Milestone
Backlog

Comments

@ghost
Copy link

ghost commented Dec 20, 2019 •
edited by ghost
Loading

There is an option called editor.cursorWidth which can be used to increase the cursor width; however, this doesn't change the terminal emulator's cursor width. This is slightly annoying. For example, please see my screenshot:

code
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Dec 20, 2019
@Tyriar
Copy link
Member

Tyriar commented Dec 27, 2019

This option was added upstream in xtermjs/xterm.js#2590 as cursorWidth, we should carry it over to vscode (xterm in vscode will get updated to have this option very soon).

@Tyriar Tyriar added feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Dec 27, 2019
@Tyriar Tyriar added this to the Backlog milestone Dec 27, 2019
@BuraChuhadar BuraChuhadar mentioned this issue Dec 31, 2019
Merged
@BuraChuhadar
Copy link
Contributor

Sending an MR for this: #87911. While adding this feature in I couldn't find the changes under 4.3.0 xterm release: https://github.com/xtermjs/xterm.js/blob/4.3.0/typings/xterm.d.ts. If you can upgrade the package.json of VSCode then this MR will start working. I tested with the latest beta release of xterm as 4.3.0 is missing this feature.

Tyriar added a commit that referenced this issue Dec 31, 2019
@Tyriar
[email protected]
65df1d9 
[email protected]

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes #86194
Fixes #87918
Part of #87456
@Tyriar Tyriar mentioned this issue Dec 31, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

87456: Configuration to increase the terminal cursor width BuraChuhadar/vscode
2 participants
@Tyriar @BuraChuhadar