Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert - move striping logic back to javascript #41905

Merged
merged 1 commit into from Jan 25, 2018
Merged

Revert - move striping logic back to javascript #41905

merged 1 commit into from Jan 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 20, 2018

No description provided.

@msftclas
Copy link

msftclas commented Jan 20, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@usernamehw
Copy link
Contributor

usernamehw commented Jan 20, 2018 •
edited
Loading

Partially reverts #41496.
I kinda asked why it's done via js and not css. I guess it's because List renders only visible part and when you scroll down and then up you get this:

keybindings_editor

cc @sandy081
I'll open similar PR for running extensions once this one is merged.

@ghost ghost closed this Jan 20, 2018
@ghost ghost deleted the revert_changes branch January 20, 2018 13:15
@ghost ghost restored the revert_changes branch January 20, 2018 13:16
@ghost ghost reopened this Jan 20, 2018
@sandy081 sandy081 added the keybindings-editor Keybinding editor issues label Jan 25, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 25, 2018
@sandy081
Copy link
Member

@usernamehw Right, good catch. Forgot about that completely.

@sandy081 sandy081 merged commit 21cf602 into microsoft:master Jan 25, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@sandy081 sandy081

Labels
keybindings-editor Keybinding editor issues
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@msftclas @usernamehw @sandy081