-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard-coded zebra in running extensions Fixes #40432 #41496
Conversation
On the second thought... why it's even using |
And why it's using |
@usernamehw all are fair suggestions feel free to add them to this PR and let me know when you are done so I review. Thanks |
Focused even rows not using proper colors Using css instead of typescript
Using css instead of typescript
There was another issue: no hover on list items. And another: click on list element usually applies CSS
So it named now as even but behave exactly as it was before (in running extensions). Changed from odd(as in CSS) to even in keybindings though... Because the first line merges with header. |
Vendor prefixes from other browsers: are those legacy from |
@usernamehw thanks for your PR I have reveiwed the runtime extensions changes and this looks good to me 👍 |
LGTM |
@usernamehw thanks a lot 🍻 |
#40432
The same way it's already done in keybindings editor.
Also, there is another issue in "running extensions":
.focused
selector not overwriting.odd
in dark and high contrast themes - it was broken before me.