Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a warning when user tries to commit, and there are unsaved files #36364

Merged
merged 1 commit into from
Dec 12, 2017
Merged

added a warning when user tries to commit, and there are unsaved files #36364

merged 1 commit into from
Dec 12, 2017

Conversation

pradeepmurugesan
Copy link
Contributor

fixes the issue #33004

@msftclas
Copy link

msftclas commented Oct 16, 2017 •
edited
Loading

CLA assistant check
All CLA requirements met.

@pradeepmurugesan pradeepmurugesan force-pushed the unsaved-files-warning-when-commit branch 2 times, most recently from 6c4e29b to a4a0742 Compare October 16, 2017 15:44
@pradeepmurugesan
Copy link
Contributor Author

screen shot 2017-10-16 at 19 12 28

The tests passed in my local.. I am not sure why it fails in the build agent. Any idea ?

@pradeepmurugesan pradeepmurugesan force-pushed the unsaved-files-warning-when-commit branch from a4a0742 to 8768aa8 Compare October 16, 2017 18:37
@joaomoreno joaomoreno added this to the Backlog milestone Oct 18, 2017
@joaomoreno joaomoreno added the git GIT issues label Oct 18, 2017
@cleidigh cleidigh mentioned this pull request Nov 19, 2017
Closed
@pradeepmurugesan pradeepmurugesan force-pushed the unsaved-files-warning-when-commit branch 2 times, most recently from ec2b384 to c121570 Compare November 21, 2017 14:59
@pradeepmurugesan pradeepmurugesan force-pushed the unsaved-files-warning-when-commit branch from c121570 to 3a10793 Compare November 21, 2017 15:37
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno merged commit 3a10793 into microsoft:master Dec 12, 2017
@joaomoreno joaomoreno modified the milestones: Backlog, December 2017 Dec 12, 2017
This was referenced Dec 12, 2017
Closed
Closed
Closed
@pradeepmurugesan pradeepmurugesan deleted the unsaved-files-warning-when-commit branch April 13, 2018 09:46
@buggymcbugfix
Copy link

Is there a flag to turn this off?

@joaomoreno
Copy link
Member

image

@buggymcbugfix
Copy link

Valeu!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
git GIT issues
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@pradeepmurugesan @msftclas @joaomoreno @buggymcbugfix