Commit should display warning if there are unsaved files in the project

[jrysig]

I often forget to save some files before SCM commit, it would be great to receive warning. Maybe it should be an optional feature.

[joaomoreno]

There isn't any current API which lets us do this. cc @jrieken

[jrieken]

Well, you could call saveAll. Not exactly a warning but it will do the job

[rkeithhill]

OMG yes! I do this way too often. It would help if VSCode used the same "Save All" shortcut that every other app on Windows uses (ctrl+shift+s). Still, this seems like a "no brainer" kind of warning. Heck I'd be fine if it was opt-in just as long as I could configure VSCode to warn me.

[jrieken]

There isn't any current API which lets us do this. cc @jrieken

Actually not so sure about that. You can loop over the array of text documents and check the isDirty-flag. Won't that do it @joaomoreno ?

[joaomoreno]

Isn't that array just the visible ones? You can have unsaved documents that won't appear in that array, right?

[jrieken]

Nope, that is all open documents, the visible once are for the editors, so no tabs

[pradeepmurugesan]

@joaomoreno & @jrieken Looks like the window.visibleTextEditors is nothing but the file that is the user is currently viewing.

If I split the screen into 2 then I get the value 2 else its always 1 irrespective of the number of tabs.
Kindly see the screen shot and let me know if I am looking at the wrong parameter under window.

[jrieken]

Yeah, don't look at editor but at documents, e.g. vscode.workspace.textDocuments

[joaomoreno]

Fixed by #36364

[bpasero]

Does not work for me:

[joaomoreno]

@bpasero Unfortunately this had to go behind a feature flag: git.promptToSaveFilesBeforeCommit. I had to disable it by default due to the smoketests. Please verify setting it to true.

[bpasero]

@joaomoreno oh ok, I was searching for a setting but was looking for "warning" and was not finding it by that.