Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote connection improvements #137863

Merged
merged 11 commits into from
Nov 25, 2021
Merged

Remote connection improvements #137863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
648e355
Add tracing to sockets
alexdima Nov 25, 2021
228ac5b
Add `traceSocketEvent` for fake socket
alexdima Nov 25, 2021
20d492a
Merge remote-tracking branch 'origin/main' into alex/remote-connectio…
alexdima Nov 25, 2021
babe6a6
Extract `ZlibInflateStream`
alexdima Nov 25, 2021
2b6fd1d
Extract `ZlibDeflateStream`
alexdima Nov 25, 2021
a3dce40
Move draining logic to `ZlibDeflateStream`
alexdima Nov 25, 2021
7b3474a
Make sure websocket frames are processed in order
alexdima Nov 25, 2021
3fb9624
Remove `KeepAlive` message and rely solely on unacknowledged messages…
alexdima Nov 25, 2021
be87ebc
Ask the client to pause writing until the socket is sent to the remot…
alexdima Nov 25, 2021
8dbd9d0
Remove unnecessary `socket.pause()` calls
alexdima Nov 25, 2021
61eda66
Merge remote-tracking branch 'origin/main' into alex/remote-connectio…
alexdima Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/vs/base/common/buffer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ export class VSBuffer {
}
}

static fromByteArray(source: number[]): VSBuffer {
const result = VSBuffer.alloc(source.length);
for (let i = 0, len = source.length; i < len; i++) {
result.buffer[i] = source[i];
}
return result;
}

static concat(buffers: VSBuffer[], totalLength?: number): VSBuffer {
if (typeof totalLength === 'undefined') {
totalLength = 0;
Expand Down Expand Up @@ -70,6 +78,12 @@ export class VSBuffer {
this.byteLength = this.buffer.byteLength;
}

clone(): VSBuffer {
const result = VSBuffer.alloc(this.byteLength);
result.set(this);
return result;
}

toString(): string {
if (hasBuffer) {
return this.buffer.toString();
Expand All @@ -90,11 +104,20 @@ export class VSBuffer {

set(array: VSBuffer, offset?: number): void;
set(array: Uint8Array, offset?: number): void;
set(array: VSBuffer | Uint8Array, offset?: number): void {
set(array: ArrayBuffer, offset?: number): void;
set(array: ArrayBufferView, offset?: number): void;
set(array: VSBuffer | Uint8Array | ArrayBuffer | ArrayBufferView, offset?: number): void;
set(array: VSBuffer | Uint8Array | ArrayBuffer | ArrayBufferView, offset?: number): void {
if (array instanceof VSBuffer) {
this.buffer.set(array.buffer, offset);
} else {
} else if (array instanceof Uint8Array) {
this.buffer.set(array, offset);
} else if (array instanceof ArrayBuffer) {
this.buffer.set(new Uint8Array(array), offset);
} else if (ArrayBuffer.isView(array)) {
this.buffer.set(new Uint8Array(array.buffer, array.byteOffset, array.byteLength), offset);
} else {
throw new Error(`Unkown argument 'array'`);
}
}

Expand Down
Loading