Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote connection improvements #137863

Merged
merged 11 commits into from
Nov 25, 2021
Merged

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Nov 25, 2021

  • adds a diagnosis mechanism to all sockets.
  • fixes a problem in WebSocketNodeSocket where a compressed frame followed by an uncompressed frame might be delivered out-of-order (unit test added).
  • removes KeepAlive messages from the protocol and no longer uses that as a mechanism to detect socket timeout
  • relies now solely on sent messages and their acknowledgement to detect a socket timeout. The socket will timeout only if there is at least one unacknowledged sent message and no server data has been received in 20s.
  • fixes Zlib error: invalid distance too far back #134429
    • where one or more keep alive messages would be sent by the client, and which would arrive at the server after the server called .pause() on the socket, but before the remote extension host receives the socket.
    • the resolution was to stop sending keep alive messages and rely solely on unacknowledged messages to detect disconnection.

@alexdima alexdima added this to the November 2021 milestone Nov 25, 2021
@alexdima alexdima self-assigned this Nov 25, 2021
@alexdima alexdima merged commit 4aad18d into main Nov 25, 2021
@alexdima alexdima deleted the alex/remote-connection-improvements branch November 25, 2021 23:53
guibber pushed a commit to guibber/vscode that referenced this pull request Nov 30, 2021
…tion-improvements

Remote connection improvements
@alexdima alexdima added the remote-connection Issues about the remote connection label Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
remote-connection Issues about the remote connection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zlib error: invalid distance too far back
1 participant