Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Semantic Tokens API check #93795

Closed
2 tasks done
alexdima opened this issue Mar 30, 2020 · 0 comments
Closed
2 tasks done

Final Semantic Tokens API check #93795

alexdima opened this issue Mar 30, 2020 · 0 comments

Comments

@alexdima
Copy link
Member

alexdima commented Mar 30, 2020

Testing - #86415 #585 #92273

Complexity: 4


Use the sample at https://github.com/microsoft/vscode-extension-samples/tree/master/semantic-tokens-sample

The sample implements a full document semantic tokens provider. Please implement a document range semantic tokens provider by doing small edits to the existing sample. Please check that:

  • when opening a file, first a request to the document range provider is made
  • once the request to the document provider is complete, no further requests are made to the document range provider

While doing this, please check that the API is available without any proposed API flags and that the JSDoc comments make sense.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants