Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the relation between Document and DocumentRange semantic tokens #94134

Closed
jrieken opened this issue Apr 1, 2020 · 1 comment
Closed

Clarify the relation between Document and DocumentRange semantic tokens #94134

jrieken opened this issue Apr 1, 2020 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue semantic-tokens Semantic tokens issues verified Verification succeeded
Milestone
March 2020

Comments

@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

re #93795

How about adding a bit of JSDoc that explains DocumentRangeSemanticTokensProvider a little, for instance that won't be used much in the presence of a DocumentSemanticTokensProvider or that/if the legends etc are independent or what happens if both are present but different extensions
@jrieken
Copy link
Member Author

jrieken commented Apr 1, 2020 •
edited
Loading

For formatters we have this on the register-function

@alexdima alexdima added the semantic-tokens Semantic tokens issues label Apr 1, 2020
@alexdima alexdima added this to the March 2020 milestone Apr 1, 2020
@alexdima alexdima added polish Cleanup and polish issue bug Issue identified by VS Code Team member as probable bug labels Apr 2, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue semantic-tokens Semantic tokens issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@jrieken @connor4312 @alexdima