Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend without modifiers #94136

Closed
jrieken opened this issue Apr 1, 2020 · 2 comments
Closed

Legend without modifiers #94136

jrieken opened this issue Apr 1, 2020 · 2 comments
Assignees
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

re #93795

This is how my legend is defined: https://github.com/microsoft/vscode-github-issue-notebooks/blob/a265e954bdc765396c6efbbb971d35f921d03a04/src/languageProvider.ts#L303

E.g it has no modifiers, only a single keyword, and when declaring tokens (using the builder) then I can only provide an in valid modifier reference (0):

https://github.com/microsoft/vscode-github-issue-notebooks/blob/a265e954bdc765396c6efbbb971d35f921d03a04/src/languageProvider.ts#L296

@jrieken
Copy link
Member Author

jrieken commented Apr 1, 2020

wait, only found this now:

push(range: Range, tokenType: string, tokenModifiers?: string[]): void;

@jrieken
Copy link
Member Author

jrieken commented Apr 1, 2020

Feel free to nuke or also make the modifier optional in the other overload

@alexdima alexdima added this to the March 2020 milestone Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants