Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Container Model does not fire events to update UI when views are moved #89170

Closed
isidorn opened this issue Jan 23, 2020 · 6 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-views Workbench view issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2020

Currently it is only possible to re-arrange the views inside the split view using drag and drop.
We should introduce commands so this feature is available to keyboard users.
Ideally this would work the following way: there is a command "Move View" , user executes that command and than can use up / down keybdingin to move the view inside the split view. Or left / right if the split view is horisontal.

fyi @sandy081 @alexdima @joaomoreno

@isidorn isidorn added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 23, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Jan 23, 2020
@microsoft microsoft deleted a comment from vscodebot bot Jan 23, 2020
@isidorn isidorn removed the feature-request Request for new features or functionality label Jan 23, 2020
@isidorn isidorn removed this from the Backlog Candidates milestone Jan 23, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jan 23, 2020

I hate the bot.

@sandy081 sandy081 added the workbench-views Workbench view issues label Jan 23, 2020
@sandy081 sandy081 self-assigned this Jan 23, 2020
@sandy081 sandy081 added this to the Backlog milestone Jan 23, 2020
@sbatten sbatten modified the milestones: Backlog, May 2020 May 7, 2020
sbatten added a commit that referenced this issue May 19, 2020
@sbatten
Copy link
Member

sbatten commented May 19, 2020

@sandy081 pushed commands for this. as discussed, the model does not fire events to update UI with changes meaning reload is required

@sbatten sbatten removed their assignment May 29, 2020
@sbatten sbatten changed the title Re-arranging views inside a split view is not accessible View Container Model does not fire events to update UI when views are moved May 29, 2020
@sandy081 sandy081 modified the milestones: May 2020, Backlog Jun 3, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jun 9, 2020

Great for pushing commands for this, but if a reload is required then the experience is not that good. What would be needed that we update the views as soon as the commands are executed? Can I help somehow here?

@sandy081
Copy link
Member

This is same as #93909

This has to be fixed in the model which need some deep knowledge.

I will take care of this in this milestone.

@sandy081 sandy081 modified the milestones: Backlog, June 2020 Jun 10, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jun 10, 2020

Great, thanks @sandy081

@sandy081 sandy081 modified the milestones: June 2020, July 2020 Jun 29, 2020
@sandy081 sandy081 modified the milestones: July 2020, August 2020 Jul 29, 2020
@sandy081 sandy081 modified the milestones: August 2020, September 2020 Aug 31, 2020
@sandy081 sandy081 modified the milestones: September 2020, October 2020 Sep 30, 2020
@sandy081 sandy081 modified the milestones: October 2020, November 2020 Oct 26, 2020
@sandy081 sandy081 added the feature-request Request for new features or functionality label Nov 9, 2020
@sandy081 sandy081 modified the milestones: January 2021, February 2021 Jan 27, 2021
@sandy081 sandy081 modified the milestones: February 2021, March 2021 Feb 22, 2021
@sandy081 sandy081 modified the milestones: March 2021, April 2021 Mar 22, 2021
@sandy081 sandy081 modified the milestones: April 2021, May 2021 Apr 26, 2021
@sandy081 sandy081 modified the milestones: May 2021, Backlog Jun 3, 2021
@sandy081 sandy081 added the *out-of-scope Posted issue is not in scope of VS Code label Dec 20, 2024
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

3 participants