Ability to disable icons and details in suggestions

[svipas]

Hi,

I'm switching between "editor.quickSuggestions" true and false, but mostly I miss the suggestions list. The issue is in VS Code it's too much noisy and distracting. But it can be easily fixed by adding an ability for users to decide if they want to see icons and details in suggestions list. Also, maxSuggestionsToShow = 12 in my opinion is too much, it should be an 8 like it's in Sublime.

In my opinion, these settings should be adjustable by the user:

const maxSuggestionsToShow = 12; // suggestWidget.ts
iconsInSuggestions: true, // editorOptions.ts
this.details = new SuggestionDetails(...); // suggestWidget.ts
.monaco-editor .suggest-widget { width: 430px; } // suggest.css

Suggestion for configurations:

"editor.suggest.showDetails": boolean, // by default true
"editor.suggest.showIcons": boolean, // by default true
"editor.suggest.maxSuggestionsToShow": number // by default 8

Before

After

I'm not touched .monaco-editor .suggest-widget { width: 430px; }, but I think then details are disabled this should be smaller than 430px.

[svipas]

I want this feature so badly, I can try all my best to create a PR if any of VS Code team member agrees on this.

[svipas]

@joaomoreno Hi, since you're back, maybe you can give your opinion on this? I can definitely create a PR.

[svipas]

@jrieken Since you're in charge now, maybe you can give your opinion on this? As I already mentioned I'm willing to create a PR if you're alright with these suggestions.

[svipas]

@jrieken Maybe I can create a PR to control these two settings?

const maxSuggestionsToShow = 12; // suggestWidget.ts
iconsInSuggestions: true, // editorOptions.ts

Settings will look like this:

"editor.suggest.maxSuggestionsToShow": number // by default 12
"editor.suggest.showIcons": boolean // by default true

[jrieken]

@svipas Sure!

[svipas]

@jrieken OMG, thanks!!!

[svipas]

Created a PR #69942

[jrieken]

👏 to @svipas

[jrieken]

fyi - we have renamed the setting to editor.maxVisibileSuggestions to align better with other setting names

[svipas]

@jrieken Thank you for info and the support, I really appreciate it. These settings will be released in 1.32 or 1.33?

[jrieken]

the setting in action, life:

[jrieken]

This is for 1.33. We plan to release 1.32 today so that tomorrow we have insider builds for 1.33 that include this change

[svipas]

@jrieken I saw you missed some renaming:

This should be maxVisibileSuggestions right?

[jrieken]

Yeah, missed that. I have change ready for it

[svipas]

@jrieken cool! I will definitely use them in tomorrow insiders 😄

[svipas]

Also, seems there's a typo: maxVisibileSuggestions should be a maxVisibleSuggestions.

[jrieken]

Good catch, pushed a fix