Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] disable autocomplete of property value #68495

Closed
svipas opened this issue Feb 12, 2019 · 8 comments · Fixed by #70090
Closed

[css] disable autocomplete of property value #68495

svipas opened this issue Feb 12, 2019 · 8 comments · Fixed by #70090
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@svipas
Copy link
Contributor

svipas commented Feb 12, 2019

I can't find how to disable CSS property value autocomplete, I'm using these settings:

  "editor.quickSuggestions": false,
  "editor.suggestOnTriggerCharacters": false,
  "editor.tabCompletion": "on",

it works perfectly in JavaScript, TypeScript, etc. But in CSS if I press tab I will get full autocomplete of property and then value. How I can disable autocomplete of value and keep only autocomplete of property? Gif below shows the issue.

css

As you can see it autocompleted almost perfectly except it automatically opened suggestion for value which I don't need since I want to go through all w based suggestions with tab and I even added in settings "editor.quickSuggestions": false which CSS should respect.

In my opinion, if quickSuggestions is false it should autocomplete only with white-space and then you can go through properties by pressing tab and then you add : which results to white-space: you can write a single letter and go through suggestions again with tab.

So to summarize it should autocomplete with only white-space and do not show suggestion list of values for that prop.

@vscodebot vscodebot bot added the editor-autoindent Editor auto indentation issues label Feb 12, 2019
@octref octref added info-needed Issue requires more information from poster css-less-scss Issues and items concerning CSS,Less,SCSS styling and removed editor-autoindent Editor auto indentation issues labels Feb 12, 2019
@octref
Copy link
Contributor

octref commented Feb 12, 2019

since I want to go through all w based suggestions with tab

How does that work? Can't you use arrow keys to select prev/next item?

@svipas
Copy link
Contributor Author

svipas commented Feb 12, 2019

No, only tab or shift+tab. I proposed this suggestion #68557, if any member of your team agrees on that proposal, then this can be closed, because I really miss suggestions list, but it's too noisy and distracting. Since there are a really small group of devs who disable suggestions and uses only tab to autocomplete, also in CSS, chances this will be re-created by someone else is very very small.

@octref octref added suggest IntelliSense, Auto Complete and removed css-less-scss Issues and items concerning CSS,Less,SCSS styling info-needed Issue requires more information from poster labels Feb 12, 2019
@octref octref assigned jrieken and unassigned jrieken Feb 12, 2019
@octref octref added feature-request Request for new features or functionality css-less-scss Issues and items concerning CSS,Less,SCSS styling and removed suggest IntelliSense, Auto Complete labels Feb 12, 2019
@octref octref added this to the Backlog milestone Feb 12, 2019
@octref
Copy link
Contributor

octref commented Feb 12, 2019

@aeschli The problem is:

  • He want to use tab/S-tab to go prev/next
  • Some CSS completion items editor.action.triggerSuggest and trap the tab/S-tab

Do you think we should add the setting?

@svipas
Copy link
Contributor Author

svipas commented Feb 28, 2019

@aeschli @octref Maybe I can help somehow to make this happen?

@aeschli aeschli changed the title CSS disable autocomplete of property value [css] disable autocomplete of property value Mar 2, 2019
@aeschli
Copy link
Contributor

aeschli commented Mar 2, 2019

Sure, a PR that adds a new setting is welcome.

@svipas
Copy link
Contributor Author

svipas commented Mar 3, 2019

@aeschli So this is related to editor.action.triggerSuggest?

@octref
Copy link
Contributor

octref commented Mar 3, 2019

Sure, thanks! Here are some pointers:

@octref octref modified the milestones: Backlog, March 2019 Mar 3, 2019
@svipas
Copy link
Contributor Author

svipas commented Mar 4, 2019

@octref Thank you!

@jrieken jrieken added the verified Verification succeeded label Mar 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants