Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload requested while installing vsix extension with dynamic contribution points #67389

Closed
aeschli opened this issue Jan 29, 2019 · 0 comments · Fixed by #67427
Closed

Reload requested while installing vsix extension with dynamic contribution points #67389

aeschli opened this issue Jan 29, 2019 · 0 comments · Fixed by #67427
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone
December/January ...

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 29, 2019 •
edited
Loading

Testing #66910

  • install eamodio.remotehub
  • restart code and open from console with code-insiders --folder-uri remotehub://github/Micorosoft/vscode-nls
  • in the explorer, note that the title shows VSCODE-NLS (REMOTEHUB)
  • install the aeschli.remotehub-companion vsix (remove zip file extension). It contains only a resourceLabelFormatters contribution, which is a dynamic contribution point
  • Note that you are asked to reload: There should not be such a prompt.

Interestingly the explorer label has already changed to VSCODE-NLS (GI*), that means the contribution has received a delta
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jan 29, 2019
This was referenced Jan 29, 2019
Closed
Closed
@sandy081 sandy081 assigned sandy081 and unassigned alexdima Jan 29, 2019
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jan 29, 2019
@sandy081 sandy081 added this to the December/January 2019 milestone Jan 29, 2019
@sandy081 sandy081 changed the title Reload requested for extension with dynamic contib points Reload requested while installing vsix extension with dynamic contribution points Jan 29, 2019
This was referenced Jan 29, 2019
Merged
Closed
sandy081 added a commit that referenced this issue Jan 29, 2019
@sandy081
Fix #67389
1066572
@aeschli aeschli added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

Successfully merging a pull request may close this issue.

Add canAddExtension & canRemoveExtension methods to IExtensionService microsoft/vscode
3 participants
@alexdima @aeschli @sandy081