Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No remove delta received when disabling extension #67391

Closed
aeschli opened this issue Jan 29, 2019 · 1 comment
Closed

No remove delta received when disabling extension #67391

aeschli opened this issue Jan 29, 2019 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues verified Verification succeeded
Milestone
December/January ...

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 29, 2019 •
edited
Loading

Testing #66910

  • install eamodio.remotehub
  • restart code and open from console with code-insiders --folder-uri remotehub://github/Micorosoft/vscode-nls
  • in the explorer, note that the title shows VSCODE-NLS (REMOTEHUB)
  • install the aeschli.remotehub-companion vsix (remove zip file extension). It contains only a resourceLabelFormatters contribution, which is a dynamic contribution point
  • reload (file different issue Reload requested while installing vsix extension with dynamic contribution points #67389)
  • explorer label has already changed to VSCODE-NLS (GI*), that means the contribution has received a delta
  • in the extensions viewlet 'disable' the remotehub-companion extension
  • VSCODE-NLS (GI*) still shown

Setting a breakpoint in labelService.ts, line 86 shows that the delta received has an empty removed delta.
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jan 29, 2019
@aeschli aeschli mentioned this issue Jan 29, 2019
Closed
@sandy081 sandy081 added extension-host Extension host issues and removed extensions Issues concerning extensions labels Jan 29, 2019
@alexdima
Copy link
Member

Nice catch!

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jan 30, 2019
@alexdima alexdima added this to the December/January 2019 milestone Jan 30, 2019
@aeschli aeschli added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
3 participants
@alexdima @aeschli @sandy081