createFileSystemWatcher API not fired when parents renamed

[NTaylorMullen]

• VSCode Version: 1.28.0
• OS Version: Win10-x64

Steps to Reproduce:

1. Create a file system watcher that monitors adds/removes:

...
        const watcher = vscode.workspace.createFileSystemWatcher('**/*.csproj*');
        const createRegistration = watcher.onDidCreate(async (uri: vscode.Uri) => {
            console.log('CSProj added: ' + uri.toString());
        });

        const deleteRegistration = watcher.onDidDelete(async (uri: vscode.Uri) => {
            console.log('CSProj removed: ' + uri.toString());
        });
...

2. Change the parent folder of a csproj

Expected: remove => create gets called on the watched files
Actual: Nothing fires

Additional Notes

Seeing this in practice in the Razor VSCode extension: https://github.com/aspnet/Razor.VSCode/blob/05b60813dd446fc4a21529a3513aeec186886465/src/Microsoft.AspNetCore.Razor.VSCode/src/RazorProjectTracker.ts#L25-L32

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Unable to find project.json or *.csproj if there are multiple *.csproj (#60381)

[bpasero]

This is a consequence of us optimizing to only report the folder rename as a change event and not the files within. We might support this scenario with a new file system implementation.

[NTaylorMullen]

This is a consequence of us optimizing to only report the folder rename as a change event and not the files within. We might support this scenario with a new file system implementation.

Interesting choice. Should I change my bits to use the onChange method?

[bpasero]

@NTaylorMullen well there is currently no workaround unless you throw in a glob pattern with the name of the folder that was renamed.

[NTaylorMullen]

Oh geez that's pretty bad. I guess we'll have to leave the behavior broken for now then. Is there another issue I can watch that tracks the effort to "support this scenario with a new file system implementation"?

[vscodebot]

We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

[Timmmm]

Is this API completely broken then? If I'm writing a C extension (for example) and a user opens Foo.cpp which contains #include "bar/Foo.h", I want to add a watch for Foo.h... but then if they rename the bar directory my extension won't be notified? Is that right?

[Mrazator]

This is a pretty big limitation for stateful language servers which cannot track project-wide diagnostics and changes - it's almost 3 years old, anyone using some workarounds (except for custom language client and filewatcher)?

@NTaylorMullen well there is currently no workaround unless you throw in a glob pattern with the name of the folder that was renamed.

Theoretically, this could work by throwing in the glob all existing folders, but once there is some folder for example copied (as it was not existing), then the server is unnotified again.

[sakivns]

This is a pretty big limitation for stateful language servers which cannot track project-wide diagnostics and changes - it's almost 3 years old, anyone using some workarounds (except for custom language client and filewatcher)?

@NTaylorMullen well there is currently no workaround unless you throw in a glob pattern with the name of the folder that was renamed.

Theoretically, this could work by throwing in the glob all existing folders, but once there is some folder for example copied (as it was not existing), then the server is unnotified again.

I have used the glob pattern "**/*" which is triggering didChangeWatchedFile for each folder delete or rename(in this case created and deleted). In case of copying a folder, the didChangeWatchedFile event is triggered for folder creation, and for all the nested specific files for which patterns are registered.

[bmewburn]

I've found this is a problem when trying to watch file changes in PHP projects when using composer. Composer appears to save files to a temp directory before renaming the dir. This results in a bunch of create events for files that only exist briefly and no events for the rename.

[znorman-harris]

Not gonna lie, I 'm having a hard time understanding why the file watching API is so broken here. If I set up a file watcher, I expect:

• Events on creation
• Events on updates
• Events on deletion
• Events on rename

In reality, you only get events when a "file" has the first three happen to it. Meaning if a "file" is deleted because a folder is deleted, you are not alerted which indicates that you are, in fact, not actually watching the files.

I would expect a watched file to count as any file in your workspace that matches your glob pattern on creation. If that file changes, I should always have an event that gets fired without having to care about the origin of the event being the file or from a parent folder. Otherwise the naming of this API does not reflect what it actually does and it will cause bugs for extension developers just like it did for me.

[Timmmm]

I still don't understand how we're supposed to use this API at all given this bug.

Suppose I'm writing an LSP for Java. I want to know about all .java files in the workspace and receive a notification when any of them is created, modified, renamed or deleted.

It sounds like the only way to do that currently is:

1. Use this API but watch everything, and then add custom logic to invalidate folder contents when the folder is deleted/renamed.
2. Just give up on this API and do the watching yourself.

Ironically the LSP specification recommends using this API because:

in our experience getting file system watching on disk right is challenging

Well, yeah. Can you really say "use our API - it's hard to get it right", when your API is so fundamentally broken?

[RobbyCBennett]

I have this problem with renamed or deleted folders for a language client I'm working on. I didn't find a workaround yet. I tried adding server capabilities for "workspace" and that didn't help.

[znorman-harris]

I have this problem with renamed or deleted folders for a language client I'm working on. I didn't find a workaround yet. I tried adding server capabilities for "workspace" and that didn't help.

I ended up doing two things:

1. You can listen to workspace events in VSCode that let you know this is happening (here is my example)
2. Send a custom message to the language server that will manually trigger whatever actions need to happen (here is what I did to remove/re-index files)