workspace/didChangeWatchedFiles is not always sent for deleted folders

[LaurentTreguier]

Sometimes, if I delete a folder, I won't get any workspace/didChangeWatchedFiles notification. I saw #141, which seemed somewhat similar, but here I'm somehow not even getting a notification about the folder itself being deleted.
I looked directly at the JSON-RPC requests and notifications that my server is receiving, in case I did something wrong, and saw no notification about anything being deleted in a session where I removed a folder.
I noticed this when switching branches in a project, where one branch has a folder that the other doesn't have.

If this is of any use:

• Platform: Linux x64 (Fedora 29)
• VSCode: 1.29.1
• vscode-languageclient: 5.1.1

I'll see if I can reproduce this on Windows to know if this is platform-specific.
EDIT: it seems to be doing the same on Windows 10 x64.

[dbaeumer]

@LaurentTreguier can you provide me with a GitHub repository with two branches that make it easy to reproduce this. I tested this locally with Windows 10 and I works for me.

[LaurentTreguier]

It looks like this might not be the correct repository for this issue, I've tried a few more things and the problem seems to lie with vscode.FileSystemWatcher (or some NodeJS API it uses). Is it implemented in the main https://github.com/Microsoft/vscode repository ?

I'm experiencing this with the language server I'm developing.
The steps to reproduce it would be:

1. Cloning https://github.com/d-language-server/dls
2. Switching it to the dls-format branch
3. Creating a VSCode extension with this code:

   import * as vsc from 'vscode';
   
   export function activate(context: vsc.ExtensionContext) {
       let watcher = vsc.workspace.createFileSystemWatcher('**/*.d');
       watcher.onDidChange(uri => console.log('change: ' + uri.toString()));
       watcher.onDidCreate(uri => console.log('create: ' + uri.toString()));
       watcher.onDidDelete(uri => console.log('delete: ' + uri.toString()));
       context.subscriptions.push(watcher);
   }

4. Launching it in a debug session and opening the dls folder
5. Switching from its dls-format branch back to its master branch, which should remove a folder named format at the root of the project containing a number of .d files

When doing this, I see some messages appearing in the debug console about files being created and changed, but no mention of files in the format folder being deleted.

[dbaeumer]

@LaurentTreguier thanks. I will move the issue to the vscode repository.

[dbaeumer]

@bpasero I can reproduce this under Windows as well using the example.

Not sure if this is a watcher or API problem (@jrieken)

[bpasero]

@LaurentTreguier please check if this could be #60813

[dbaeumer]

Looks like. We do send a delete event in the example but only for delete: file:///c%3A/Users/dirkb/Projects/mseng/VSCode/Playgrounds/dls/format

[bpasero]

/duplicate #60813

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!