Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In multiple overlapping folders, ctrl+p shows duplicates for root files #29719

Closed
alexdima opened this issue Jun 28, 2017 · 1 comment
Closed

In multiple overlapping folders, ctrl+p shows duplicates for root files #29719

alexdima opened this issue Jun 28, 2017 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone
June 2017

Comments

@alexdima
Copy link
Member

alexdima commented Jun 28, 2017 •
edited
Loading

Testing #29176

  • open vscode
  • add root folder vscode\src
  • search for a file which is not in the recently used section, but which is inside vscode\src (at the top)
  • e.g. cli.js
  • note: if the file is in the recent list it is not duplicated

screen shot 2017-06-28 at 10 30 53
@isidorn isidorn removed their assignment Jun 28, 2017
@bpasero bpasero assigned roblourens and unassigned bpasero Jun 28, 2017
@bpasero bpasero added workbench-multiroot Multi-root (multiple folders) issues search Search widget and operation issues bug Issue identified by VS Code Team member as probable bug labels Jun 28, 2017
@roblourens roblourens added this to the June 2017 milestone Jun 28, 2017
@roblourens
Copy link
Member

I think I missed this because as you point out, they get deduped if they show up in the recently used section. This is actually going to be a pain to fix using find unless I dedupe results after find runs.

roblourens added a commit that referenced this issue Jun 29, 2017
@roblourens
Fix #29719 - exclude nested folders during search to not show dupes
16f997c
@bpasero bpasero added the verified Verification succeeded label Jun 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@roblourens @bpasero @isidorn @alexdima