Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: multi root explorer #29176

Closed
3 tasks done
isidorn opened this issue Jun 21, 2017 · 7 comments
Closed
3 tasks done

Test: multi root explorer #29176

isidorn opened this issue Jun 21, 2017 · 7 comments
Labels
testplan-item workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2017

Complexity: 4
Refs: #29030

This milestone we have started to work on the multi root experience, currently this is only available on insiders. Verify:

  • Quickly check that the single root explorer is the same as before
  • You can nicely transition from single root to multi root (from File menu, from explorer context menu, via global action)
  • View state is preserved in the explorer between restarts (focus, expand state, opened editor)
  • The active file is always revealed when switching between editors
  • You can drag and drop in the explorer (also between different roots)
  • All the context menu actions make sense (check the ones for the roots as well as clicking into the empty space outside any root)
  • All the explorer actions (top right) make sense and target the currently selected element
  • Deleting, renaming, adding file should work as before
  • Check the case when you have the same folder opened twice - once the parent and once any of its children (try to rename / delete something in that folder, both parents should get updated)
  • Have a files.exclude setting in each folder and make sure that it is exactly respected in each folder
  • Delete the root folder in some other tool while vscode is open. Make sure vscode handles this case gracefully
  • Be creative in trying to break the explorer
@isidorn isidorn added workbench-multiroot Multi-root (multiple folders) issues testplan-item labels Jun 21, 2017
@isidorn isidorn added this to the June 2017 milestone Jun 21, 2017
@Dominik-K
Copy link

Failures:

  • No context-menu on folders (sub & root).
  • "Copy" (Cmd+C or via context-menu) not working -> Not pasting with Cmd+V & "Paste" invisible in context menu.

Working:

  • Moving a file or folder with drag & drop.
  • Context-menu on files.

Questions:

  • How to choose "Copy" while drag & drop, e.g. while holding Ctrl key?
  • Undo for drag & drop operations planned?

@isidorn
Copy link
Contributor Author

isidorn commented Jun 21, 2017

@Dominik-K this is work in progess, please do not test it out yet.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 27, 2017

Please test this with the latest insiders build found on https://vscode-builds.azurewebsites.net/builds/insider since the released insider build has an issue with explorer reacting to file events

@alexdima
Copy link
Member

alexdima commented Jun 28, 2017

Works quite well 👍

The only question for me is the use-case of opening overlapping folders. Perhaps in this case, the overlapping folder can be removed from the container:

e.g.

  • open root folder vscode
  • open root folder vscode\src
  • perhaps in the Explorer, the folder src should not be shown anymore and it should only be shown as a top level root folder.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 28, 2017

Thanks. I am still questioning this scenario in general.

An alternative would to what you are suggesting is to show the vscode/src but grayed out and not be exapndable. That way it would be clearer to the user.

@bpasero
Copy link
Member

bpasero commented Jun 28, 2017

I can cover @stevencl on Linux now.

@bpasero
Copy link
Member

bpasero commented Jun 28, 2017

Cool!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

7 participants