Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize full-width space character (render whitespace in selection) #2085

Closed
kuyur opened this issue Jan 18, 2016 · 6 comments
Closed

Visualize full-width space character (render whitespace in selection) #2085

kuyur opened this issue Jan 18, 2016 · 6 comments
Labels
editor-rendering Editor rendering issues *extension-candidate Issue identified as good extension implementation feature-request Request for new features or functionality
Milestone
Backlog

Comments

@kuyur
Copy link

kuyur commented Jan 18, 2016

Hope to support visualizing full-width space character with "○".
@weinand
Copy link
Contributor

weinand commented Jan 18, 2016

@kuyur I assume you refer to the "editor.renderWhitespace" setting which shows tab characters but does not show spaces? What do your mean with "full-width space character"?

@weinand weinand added the info-needed Issue requires more information from poster label Jan 18, 2016
@kuyur
Copy link
Author

kuyur commented Jan 18, 2016

full-width space is used in Japanese and Chinese. for example, 　, you can select the text and will see that its width is double of that of normal Latin character.

@weinand weinand added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Jan 18, 2016
@alexdima alexdima changed the title Visualize full-width space character Visualize full-width space character (render whitespace in selection) Jan 18, 2016
@sijad sijad mentioned this issue Feb 10, 2016
Closed
@glen-84
Copy link

glen-84 commented Jun 18, 2016

Related to #1477.

@alexdima alexdima added this to the Backlog milestone Jul 5, 2016
@alexdima alexdima added editor-core Editor basic functionality and removed editor-core-view labels Aug 30, 2016
@alexdima alexdima removed their assignment Oct 27, 2016
@ghost
Copy link

ghost commented Feb 23, 2017 •
edited by liuliangsir
Loading

+1
Because i encountered syntax error in js file which contain some full-width character
Sadly, vscode editor seem not to find out full-width character

@kuyur
Copy link
Author

kuyur commented Feb 23, 2017

I hope that the full-width space character can be always rendered, not only when it is selected.

@spywhere spywhere mentioned this issue May 28, 2017
Merged
@alexdima alexdima added editor-rendering Editor rendering issues and removed editor-core Editor basic functionality labels Nov 22, 2017
Tyriar added a commit that referenced this issue May 21, 2019
@Tyriar
[email protected]
467557c 
Merge pull request #2081 from Tyriar/xterm-tests
Merge pull request #2085 from Tyriar/a11y_fix
Merge pull request #2088 from Tyriar/fix_coveralls
Merge pull request #2092 from Tyriar/layering
Merge pull request #2094 from Tyriar/2005_colormanager
Merge pull request #2096 from Tyriar/render_coordinator
Merge pull request #2098 from Tyriar/2093_logo_demo
Merge pull request #2100 from Tyriar/2099_pausing
Merge pull request #2101 from Tyriar/bad_comment_
Merge pull request #2109 from Tyriar/2107_cursor_report
Merge pull request #2113 from Tyriar/2111_automate_patch_release
Merge pull request #2110 from Tyriar/split_out_integration
Merge pull request #2114 from Tyriar/consolidate_api_test_timeout

Diff: xtermjs/xterm.js@2d59185...93c1b89
@Tyriar Tyriar mentioned this issue May 21, 2019
Merged
@alexdima alexdima added the *extension-candidate Issue identified as good extension implementation label Oct 23, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 23, 2019

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
editor-rendering Editor rendering issues *extension-candidate Issue identified as good extension implementation feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@glen-84 @kuyur @weinand @alexdima